Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to Modify File Name Encoding in orc/code_orchestration.py #115

Open
VAN613 opened this issue Dec 19, 2024 · 0 comments
Open

Proposal to Modify File Name Encoding in orc/code_orchestration.py #115

VAN613 opened this issue Dec 19, 2024 · 0 comments

Comments

@VAN613
Copy link

VAN613 commented Dec 19, 2024

Hello,

I hope this message finds you well. I would like to propose a modification to the orc/code_orchestration.py file to address an issue with file name encoding when uploading to BLOB storage.

Currently, the code contains the following line:

arguments["sources"] = sources

This setup causes file names in Japanese to become garbled when uploaded. To resolve this issue, I suggest changing the line as follows:

import urllib.parse
arguments["sources"] = urllib.parse.unquote(sources)

Would there be any concerns with implementing this change?

Additionally, although it might not be necessary, I found that changing the example file names in orc/plugins/Conversation/Answer/skprompt.txt to Japanese also helped resolve the garbling issue.

Thank you for considering this proposal. I look forward to your feedback.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant