From 14a4cfe447e9f0b492d62c412d0456612c39e780 Mon Sep 17 00:00:00 2001
From: B-2U <alexkao1439@gmail.com>
Date: Sun, 25 Feb 2024 13:36:24 +0800
Subject: [PATCH] prevent unnecessary lock acquirement

---
 src/cmds/leaderboard.rs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/cmds/leaderboard.rs b/src/cmds/leaderboard.rs
index 129ced8..123236a 100644
--- a/src/cmds/leaderboard.rs
+++ b/src/cmds/leaderboard.rs
@@ -82,11 +82,14 @@ async fn func_top(ctx: Context<'_>, region: Region, ship: Ship) -> Result<(), Er
         }
     };
     // color patrons
-    lb_players.iter_mut().take(15).for_each(|p| {
-        if ctx.data().patron.read().check_player(&p.uid) {
-            p.color = "#e85a6b".to_string();
-        }
-    });
+    {
+        let patrons_rg = ctx.data().patron.read();
+        lb_players.iter_mut().take(15).for_each(|p| {
+            if patrons_rg.check_player(&p.uid) {
+                p.color = "#e85a6b".to_string();
+            }
+        })
+    };
 
     // if user is in the leaderboard, set color and swap its index if needed
     let truncate_len = if let Some((p_index, p)) =