Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ParentData] Rewrite Parent Data code #2

Open
sctop opened this issue Aug 18, 2023 · 0 comments
Open

[ParentData] Rewrite Parent Data code #2

sctop opened this issue Aug 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@sctop
Copy link
Member

sctop commented Aug 18, 2023

ParentData was first introduced to solve the problem that "a child could not access its parents' data". With ParentData, a parent can pass its own data (e.g. name and namespace) to their children, so that children can access them for later use.

Currently, ParentData is used primarily in event entries, where an event story/battle/ui needs to know its parents, to be able to display their parents' names (i.e. the event name).

The issue with ParentData is how messy the code is. We've observed that a parent can exist multiple times when data is exported, creating a completely unnecessary and ugly structure due to poor code lines. Therefore the code needs to be rewritten in a clearer and non-buggy way.

Expecting the rewriting will be in place in September or October this year.

BE ADVISED: I personally DO NOT recommend other people to touch the code because I CAN NOT EVEN figure out what exactly it is!

@sctop sctop added bug Something isn't working enhancement New feature or request labels Aug 18, 2023
@sctop sctop self-assigned this Aug 18, 2023
@sctop sctop moved this to Todo in BOI解析器开发 Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant