-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Progress bar for pipelines #22
Comments
Goodmorning @rgriff23 , I would like to work on this issue, could you please assign it to me? Also, if I have any doubts, can I reach out to you on this thread? |
Hi @ParthJohri! You can certainly pick this up - I suggest tagging @seanggani for questions. |
Hi @ParthJohri , apologies for missing your comment! Please let us know if there's anything we can help with |
Thank you, @seanggani @rgriff23 for assigning the issue. Screen Recording & ScreenshotsI implemented this progress bar using progressbar2 package instead of tqdm on the page to show how to instantiate a Gemini model class to interact with the Gemini API: Screen.Recording.2024-07-02.at.21.18.50.movSo we have to do the same on the pipeline page right? Could you please tell if I am understand it wrong or moving in right direction? |
Thanks @ParthJohri, this is a great start! I'll defer to @seanggani and @breakbotz to review the implementation details. My main suggestion is for the progress bar to be implemented as an optional argument for the run function, e.g., progress_bar=True displays a progress bar, and I'd suggest it defaults to False. This approach ensures that the progress bar is only shown when it is actually useful, avoiding unnecessary clutter when the pipeline runs quickly due to cached results (which is the case in all of our documentation tutorials) or because the user is testing out a simple pipeline. I'd suggest we introduce the progress bar explicitly in the "Building Your First ARTKIT Pipeline" tutorial, in the section where we introduce the core ARTKIT functions. Otherwise, I don't think we should include it throughout our documentation tutorials since all the tutorials are using cached results to ensure reproducibility, and we don't want to display progress bars which could give a misleading perception of how fast the pipelines run when there is no cache. |
@ParthJohri the core team will need to discuss implementation internally before we can give feedback for you to move forward. Thanks in advance for your patience! |
Thank you @rgriff23 for your reply, I would be waiting for the response to the implementation. |
@ParthJohri thanks for making the first pass at solving this! After discussing internally, we realized this is a more complex implementation which needs to be implemented in a dependency called fluxus. The change will require a good understanding of the underlying architecture of Conclusion from our technical discussion:
Some suggestions for alternative ways to contribute to
Let me know what you think! |
@ParthJohri thanks for making the first pass at solving this! After discussing internally, we realized this is a more complex change which needs to be implemented in a dependency called fluxus. The change will require a good understanding of the underlying architecture of FYI - some details from our technical discussion:
Some suggestions for alternative ways to contribute to
Let me know what you think! |
Thank you @rgriff23 for the clarification, I would be glad to work on the beginner issues and make my way to understand the code base to contribute further. I will be happy to be assigned the documentation and explanation part. |
@ParthJohri great! Do you mind checking the beginner issues and commenting on the one you'd like to pick up first? I can't assign an external contributor until you engage with the issue. |
Absolutely @rgriff23 thank you so much, also sorry for not being able to reply promptly, I am unwell at the moment. |
We plan to add an optional progress bar to the
run
method in the dependency,fluxus
: BCG-X-Official/fluxus#23It will then be available to the
run
method inartkit
and we should introduce it in the "Building Your First ARTKIT Pipeline" tutorial, specifically in the section where we introduce the core ARTKIT functions.Once the progress bar is added and we have updated the
fluxus
version inartkit
, we will re-open this issue.The text was updated successfully, but these errors were encountered: