Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy RandomState is now legacy #93

Open
jason-bentley opened this issue Jan 8, 2021 · 0 comments
Open

numpy RandomState is now legacy #93

jason-bentley opened this issue Jan 8, 2021 · 0 comments
Assignees
Labels
API New feature or request
Milestone

Comments

@jason-bentley
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The RandomState used from numpy is now legacy (https://numpy.org/doc/1.19/reference/random/legacy.html) and has been indirectly replaced by Generator (https://numpy.org/doc/stable/reference/random/generator.html).
This is also something that may impact scikit-learn in the future and a PR has been opened regarding (scikit-learn/scikit-learn#16988).

Describe the solution you'd like
Given the dependency upon scikit-learn and the fact that RandomState is now legacy we should be proactive in ensuring we make the neccesary updates should RandomState be retired and/or scikit-learn replaces RandomState.

@j-ittner j-ittner added the API New feature or request label Sep 1, 2021
@j-ittner j-ittner added this to the 2.0.0 milestone Sep 1, 2021
@j-ittner j-ittner modified the milestones: 2.0.0, 2.1.0 Sep 7, 2022
@j-ittner j-ittner modified the milestones: 2.1.0, 2.2.0 Sep 27, 2022
@j-ittner j-ittner modified the milestones: 2.2.0, 2.3.0 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants