[wallet] [zk] Properly introduce UpdateNullifierNoteMap(WithTx) to AddToWallet

[ch4ot1c]

Zcash:
https://github.com/zcash/zcash/blob/13b41a6760c67524dd77afc67e7d556ec1ea71be/src/wallet/wallet.cpp#L1114
bool CWallet::AddToWallet(const CWalletTx& wtxIn, bool fFromLoadWallet, CWalletDB* pwalletdb);

https://github.com/zcash/zcash/blob/13b41a6760c67524dd77afc67e7d556ec1ea71be/src/wallet/wallet.cpp#L1263
bool AddToWalletIfInvolvingMe(const CTransactionRef& tx, const CBlockIndex* pIndex, int posInBlock, bool fUpdate) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);

Bitcoin signatures:
bool AddToWallet(const CWalletTx& wtxIn, bool fFlushOnClose=true);
bool AddToWalletIfInvolvingMe(const CTransactionRef& tx, const CBlockIndex* pIndex, int posInBlock, bool fUpdate) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[ch4ot1c]

#35 puts us on track for this change

[ch4ot1c]

IncOrderPosNext takes a WalletDB in Zcash, but WalletBatch in Bitcoin.