Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customise reporting #405

Open
StefanBRas opened this issue May 7, 2024 · 3 comments
Open

Customise reporting #405

StefanBRas opened this issue May 7, 2024 · 3 comments

Comments

@StefanBRas
Copy link

StefanBRas commented May 7, 2024

Hey!

I'm trying out diff_cover in Github Actions. Github Actions supports annotations where If I in a job run print out something like

::warning file=my_file,line=2,title=Missing Coverage::Line XXX is missing coverage

I will get these in the job logs:
image
image

And in the Pull request view it will show this:
image

Which is very neat.

However right now, I need to use diif_cover to create a json and the parse that to print out the annotations. I think it would make sense to have it as an option in diff_cover, but to me it looks like there's no way to inject custom reporting.

I think this could be done either using a hook system like with violations or by letting users specify "--format" or something.

I can contribute the PR, just wanted to hear what way you think it should be implemented

@wyardley
Copy link

wyardley commented Jan 3, 2025

Similar issue here. In the case of sqlfluff, it already has a native github annotations output format, but in the case where I'm using diff-quality --compare-branch origin/main --violations sqlfluff, I can't get the annotations for findings only.

I've seen multiple tools (sqlfluff, pylint, etc.), either directly or with plugins have a --format github or --format github-native or similar.

In this case, the format would look something like

::warning title=SQLFluff,file=path/to/file.sql,line=189,col=1,endLine=189,endColumn=9::LT02: Expected indent of 12 spaces. [layout.indent]

vs something like

path/to/file.sql:14: Unnecessary trailing whitespace.

@Bachmann1234
Copy link
Owner

Bachmann1234 commented Jan 6, 2025

I'm open to the idea. I'll take a look at a pr if one comes in. Sorry this issue must had gotten lost in the shuffle.

@timkrins
Copy link

I also have this requirement, and have created #432 as an example of the report generator for this use case.

A hook / plugin system would be cool - the logic does not feel very extendable right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants