Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnumServiceProvider breaks nova translations #342

Closed
cweiske opened this issue Nov 10, 2023 · 3 comments
Closed

EnumServiceProvider breaks nova translations #342

cweiske opened this issue Nov 10, 2023 · 3 comments

Comments

@cweiske
Copy link

cweiske commented Nov 10, 2023

When using this package, translations in Laravel Nova are broken. See #136 for an earlier issue.

This is the same issue as msurguy/Honeypot#64 - see there for a truckload of other linked issues.

BenSampo\Enum\EnumServiceProvider is booted very early, and already uses the translator.
Laravel\Nova\NovaServiceProvider is booted later and adds additional configuration to the translator.
Unfortunately, the translator has already loaded its configuration because of EnumServiceProvider, and thus ignores the "new" configuration provided by Nova.

When EnumServiceProvider does not use the translator, everything is fine.


An attempt to fix this was tried in #145 and #141, and the latter was merged. This fix was reverted by #227, so the problem is back.

@spawnia
Copy link
Collaborator

spawnia commented Nov 28, 2023

Does #324 not fix this for you? Are you using the latest version?

@cweiske
Copy link
Author

cweiske commented Dec 11, 2023

We are using Laravel 8.83.27 and thus cannot use laravel-enum v6 - we are stuck with v4.

@spawnia
Copy link
Collaborator

spawnia commented Dec 11, 2023

This package will not be developed further, and I will not backport fixes to older versions, thus I am closing this issue.

@spawnia spawnia closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants