Munged add-on location

[SlimeDog]

Expected behavior

Clean server start-up

Observed/Actual behavior

On start-up

[23:21:52] [Server thread/ERROR]: [BentoBox-Biomes] Biomes-2.2.0-b258-1714890112438.jar must be in the BentoBox/addons folder! Trying to move it there...
[23:21:52] [Server thread/ERROR]: [BentoBox-Biomes] Biomes-2.2.0-b258-1714890112438.jar moved successfully.
[23:21:53] [Server thread/ERROR]: [BentoBox-Challenges] Challenges-1.3.0-b546-1714890112917.jar must be in the BentoBox/addons folder! Trying to move it there...
[23:21:53] [Server thread/ERROR]: [BentoBox-Challenges] Challenges-1.3.0-b546-1714890112917.jar moved successfully.
[23:21:53] [Server thread/ERROR]: [BentoBox-BSkyBlock] BSkyBlock-1.18.0-b763-1714890113790.jar must be in the BentoBox/addons folder! Trying to move it there...
[23:21:53] [Server thread/ERROR]: [BentoBox-BSkyBlock] BSkyBlock-1.18.0-b763-1714890113790.jar moved successfully.
[23:21:54] [Server thread/ERROR]: [BentoBox-Level] Level-2.13.0-b565-1714890114334.jar must be in the BentoBox/addons folder! Trying to move it there...
[23:21:54] [Server thread/ERROR]: [BentoBox-Level] Level-2.13.0-b565-1714890114334.jar moved successfully.
[23:22:34] [Server thread/WARN]: [BentoBox] No Regenerator found for craftbukkit, falling back to Bukkit API.

BBox addons are in the correct subdirectory, from previous installations.

Steps/models to reproduce

• Update to BentoBox 2.4.0-b2606
• Start server
• Observe errors and warnings in console/log

BentoBox version

> bbox version
[23:26:21 INFO]: Running PAPER 1.20.6.
[23:26:21 INFO]: (git-Paper-40 (MC: 1.20.6))
[23:26:21 INFO]: BentoBox version: 2.4.0-SNAPSHOT-b2606
[23:26:21 INFO]: Database: JSON
[23:26:21 INFO]: Loaded Game Worlds:
[23:26:21 INFO]: world_skyblock (SkyBlock): Overworld, Nether, The End
[23:26:21 INFO]: Loaded Addons:
[23:26:21 INFO]: Biomes 2.2.0-SNAPSHOT-b258 (ENABLED)
[23:26:21 INFO]: BSkyBlock 1.18.0-SNAPSHOT-b763 (ENABLED)
[23:26:21 INFO]: Challenges 1.3.0 (ENABLED)
[23:26:21 INFO]: ExtraMobs 1.13 (ENABLED)
[23:26:21 INFO]: Level 2.13.0-SNAPSHOT-b565 (ENABLED)

Plugin list

Irrelevant; can be provided if required.

Other

Start-up without error in BentoBox 2.4.0-b260

[BONNe]

Did you place the bentobox addon in plugins directory?

[SlimeDog]

Did you place the bentobox addon in plugins directory?

As noted above:

BBox addons are in the correct subdirectory, from previous installations.

I think bbox version would not find them if they were in plugins.

Here is the tree

$ ls -1 plugins/BentoBox*.jar plugins/BentoBox/addons/*.jar
plugins/BentoBox-2.4.0-b2606.jar
plugins/BentoBox/addons/Biomes-2.2.0-b258.jar
plugins/BentoBox/addons/BSkyBlock-1.18.0-b763.jar
plugins/BentoBox/addons/Challenges-1.3.0-b546.jar
plugins/BentoBox/addons/ExtraMobs-1.13-b24.jar
plugins/BentoBox/addons/Level-2.13.0-b565.jar

[tastybento]

No errors on Spigot, but seen on Paper. Seems to be related to "PluginRemapper" and Pladdons:

[09:18:59 INFO]: [PluginRemapper] Remapping plugin 'plugins/BentoBox/addons/Level-2.13.0-SNAPSHOT-LOCAL.jar'...
[09:18:59 INFO]: [PluginRemapper] Done remapping plugin 'plugins/BentoBox/addons/Level-2.13.0-SNAPSHOT-LOCAL.jar' in 71ms.
[09:18:59 INFO]: [BentoBox-Level] Loading server plugin BentoBox-Level v2.13.0-SNAPSHOT-LOCAL
[09:18:59 ERROR]: [BentoBox-Level] Level-2.13.0-SNAPSHOT-LOCAL-1714925939256.jar must be in the BentoBox/addons folder! Trying to move it there...
[09:18:59 ERROR]: [BentoBox-Level] Level-2.13.0-SNAPSHOT-LOCAL-1714925939256.jar moved successfully.

The Pladdons get moved to a folder called plugins/.paper-remapped/unknown-origin

Continuing to investigate...

[tastybento]

Right now this is just cosmetic.

[SlimeDog]

OK. Thanks for investigating. As with so many plugins, the new Paper changes required plugin changes.

[SlimeDog]

PaperMC may have fixed it in build 44. I'll confirm after a few more restarts. Nope...

[SlimeDog]

The Pladdons get moved to a folder called plugins/.paper-remapped/unknown-origin

Continuing to investigate...

The Paper remapper doesn't understand JAR files outside of ./plugins. Among other things, it keeps piling them up. Due to the unstable nature of Paper 1.20.6 and plugin compatibility, I reboot often. I found 40+ "versions" of the BentoBox addons in ./plugins/.paper-remapped/unknown-origin/BentoBox/addons. I now remove them in preprocessing on server start-up. Interestingly, the file placement isn't consistent (note ExtraMobs):

├── unknown-origin
│   ├── BentoBox
│   │   └── addons
│   │       ├── Biomes-2.2.0-b258-1714973408458.jar
│   │       ├── BSkyBlock-1.18.0-b763-1714973410134.jar
│   │       ├── Challenges-1.3.0-b546-1714973409209.jar
│   │       └── Level-2.13.0-b565-1714973410832.jar
│   ├── ExtraMobs-1.13-b24-1714973409082.jar
│   └── index.json

[tastybento]

Hmm. I might take a wait and see approach here or maybe report the issue to Paper. We could do a "hack" if we have to clear out the junk but that would be a last resort.

[SlimeDog]

Agreed that this seems to be a Paper issue. I'll leave it in your hands.