Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set maximum call and concurent call separately #14

Open
bxcodec opened this issue Nov 29, 2018 · 5 comments
Open

feat: Set maximum call and concurent call separately #14

bxcodec opened this issue Nov 29, 2018 · 5 comments
Assignees

Comments

@bxcodec
Copy link
Contributor

bxcodec commented Nov 29, 2018

Current version:

In the current version, we can set the maximum concurrent call that was called concurrently.
For example:

./gubrak -r 100 -c config.json

This command will do 100 call with 100 concurrent request. So if I set the r param to 1000 then I will make a 1000 call with concurently.

What I proposed is:

How about making maximum call but we can set the maximum concurrent call separately
maybe something like this:

./gubrak -r 1000 -concurent 100 -c config.json

I'll expect this, we made a 1000 call in total, but separated in 10 times (1000/100) or to simplify, it's like doing batching calling 100 call per batch until it reach 1000 as the targeted total call.

@bxcodec
Copy link
Contributor Author

bxcodec commented Nov 29, 2018

Because we don't have any clear roadmap yet, I think we can add this one to our development plan.

@wuriyanto48
Copy link
Contributor

so we can control how many goroutines we will launch and also how many requests we will launch, but not directly related, is that right @bxcodec ?, i think its good.
is the -concurrent flag mandatory? if not, will the -concurrent use the size of request?

@bxcodec
Copy link
Contributor Author

bxcodec commented Nov 29, 2018

I think it's better to use a default parameter.

@wuriyanto48
Copy link
Contributor

well,, now we just have to think about the design of this new feature

@bxcodec
Copy link
Contributor Author

bxcodec commented Dec 28, 2018

So who will add this feature?
It's so busy lately, but maybe in the next week, I'll try to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants