.github/workflows/build-classic.yml

@@ -18,7 +18,7 @@ jobs:
 
     steps:
       - name: Checkout addon
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
 
     steps:
       - name: Checkout addon
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/pull_request.yml

@@ -8,7 +8,7 @@ jobs:
 
     steps:
       - name: Checkout addon
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Run luacheck
         uses: BigWigsMods/actions/luacheck@master

.luacheckrc

@@ -14,6 +14,11 @@ ignore = {
 	"432/self", -- Shadowing an upvalue argument
 }
 globals = {
+	-- Addons
+	"ElvUI",
+	"LibStub",
+	"Tukui",
+
 	-- wow std api
 	"abs",
 	"acos",
@@ -83,135 +88,72 @@ globals = {
 	"tremove",
 	"wipe",
 
-	-- framexml
-	"AuraUtil",
-	"CopyTable",
-	"getprinthandler",
-	"hash_SlashCmdList",
-	"setprinthandler",
-	"tContains",
-	"tDeleteItem",
-	"tInvert",
-	"tostringall",
-	"UIPanelWindows",
+	-- FrameXML
 	"CanOpenPanels",
+	"ChatTypeInfo",
+	"CopyTable",
+	"FriendsFrame",
+	"GameFontNormal",
+	"GameTooltip",
+	"GameTooltip_Hide",
 	"GetUIPanel",
 	"GetUIPanelWidth",
+	"SecondsToTime",
+	"SlashCmdList",
+	"UIPanelWindows",
+	"UIParent",
+	"tContains",
 
-	-- everything else
-	"AlertFrame",
+	-- API
 	"Ambiguate",
 	"BNGetFriendIndex",
 	"BNInviteFriend",
-	"BNIsSelf",
 	"BNSendWhisper",
-	"BasicMessageDialog",
-	"BossBanner",
+	"C_AddOns",
 	"C_BattleNet",
-	"C_CVar",
 	"C_ChatInfo",
-	"C_EncounterJournal",
-	"C_FriendList",
 	"C_GuildInfo",
+	"C_Item",
 	"C_Map",
 	"C_PaperDollInfo",
 	"C_PartyInfo",
-	"C_RaidLocks",
-	"C_Scenario",
 	"C_Spell",
 	"C_Timer",
-	"C_TradeSkillUI",
-	"C_UIWidgetManager",
-	"ChatFrame_ImportAllListsToHash",
-	"ChatTypeInfo",
-	"CheckInteractDistance",
-	"CinematicFrame_CancelCinematic",
-	"CollapseFactionHeader",
+	"C_UnitAuras",
 	"CombatLogGetCurrentEventInfo",
-	"CombatLog_String_GetIcon",
 	"CreateFrame",
 	"DemoteAssistant",
 	"DoReadyCheck",
-	"EJ_GetCreatureInfo",
 	"EJ_GetEncounterInfo",
-	"EJ_GetTierInfo",
-	"ElvUI",
-	"EnableAddOn",
-	"ExpandFactionHeader",
-	"FlashClientIcon",
-	"FriendsFrame",
-	"GameFontHighlight",
-	"GameFontNormal",
-	"GameTooltip",
-	"GameTooltip_Hide",
-	"GetAddOnDependencies",
-	"GetAddOnEnableState",
-	"GetAddOnInfo",
-	"GetAddOnMetadata",
-	"GetAddOnOptionalDependencies",
 	"GetAverageItemLevel",
 	"GetBattlefieldStatus",
 	"GetCVarBool",
 	"GetChannelDisplayInfo",
 	"GetChannelName",
-	"GetDetailedItemLevelInfo",
-	"GetDifficultyInfo",
-	"GetExpansionLevel",
-	"GetFactionInfo",
-	"GetFramesRegisteredForEvent",
 	"GetGuildInfo",
 	"GetGuildRosterInfo",
 	"GetInstanceInfo",
 	"GetInventoryItemLink",
-	"GetInventoryItemQuality",
-	"GetItemCount",
-	"GetItemSpell",
-	"GetItemStats",
 	"GetLFGMode",
 	"GetLocale",
 	"GetMaxBattlefieldID",
 	"GetMaxLevelForLatestExpansion",
-	"GetNumAddOns",
 	"GetNumDisplayChannels",
-	"GetNumFactions",
 	"GetNumGroupMembers",
 	"GetNumGuildMembers",
 	"GetNumSubgroupMembers",
-	"GetPartyAssignment",
-	"GetPlayerFacing",
-	"GetProfessionInfo",
-	"GetProfessions",
 	"GetRaidDifficultyID",
 	"GetRaidRosterInfo",
 	"GetRaidTargetIndex",
 	"GetReadyCheckStatus",
 	"GetReadyCheckTimeLeft",
 	"GetRealZoneText",
 	"GetRealmName",
-	"GetSpecialization",
-	"GetSpecializationInfoByID",
-	"GetSpecializationRole",
 	"GetSpecializationRoleByID",
-	"GetSpellBookItemName",
-	"GetSpellBookItemTexture",
-	"GetSpellCharges",
-	"GetSpellCooldown",
-	"GetSpellDescription",
-	"GetSpellInfo",
-	"GetSpellLink",
-	"GetSpellTabInfo",
-	"GetSpellTexture",
-	"GetSubZoneText",
-	"GetTexCoordsForRole",
-	"GetTexCoordsForRoleSmallCircle",
 	"GetTime",
-	"GetTrackedAchievements",
 	"GuildControlGetNumRanks",
 	"GuildControlGetRankName",
 	"InCombatLockdown",
-	"IsAddOnLoadOnDemand",
-	"IsAddOnLoaded",
-	"IsAltKeyDown",
 	"IsControlKeyDown",
 	"IsEncounterInProgress",
 	"IsEveryoneAssistant",
@@ -220,61 +162,31 @@ globals = {
 	"IsInGuild",
 	"IsInInstance",
 	"IsInRaid",
-	"IsItemInRange",
-	"IsLoggedIn",
-	"IsPartyLFG",
 	"IsShiftKeyDown",
-	"IsSpellKnown",
-	"IsTestBuild",
-	"LFGDungeonReadyPopup",
-	"LibStub",
-	"LoadAddOn",
-	"LoggingCombat",
-	"MovieFrame",
-	"ObjectiveTrackerFrame",
 	"PlaySound",
-	"PlaySoundFile",
-	"PlayerHasToy",
 	"PromoteToAssistant",
-	"RaidBossEmoteFrame",
-	"RaidNotice_AddMessage",
-	"RaidWarningFrame",
-	"RolePollPopup",
-	"SecondsToTime",
 	"SendChatMessage",
 	"SetEveryoneIsAssistant",
 	"SetPortraitToTexture",
 	"SetRaidDifficulties",
-	"SetRaidTarget",
-	"SlashCmdList",
 	"StopSound",
-	"Tukui",
-	"UIErrorsFrame",
-	"UIParent",
 	"UninviteUnit",
 	"UnitAffectingCombat",
-	"UnitAura",
-	"UnitCanAttack",
 	"UnitCastingInfo",
 	"UnitChannelInfo",
 	"UnitClass",
 	"UnitClassBase",
-	"UnitDetailedThreatSituation",
-	"UnitEffectiveLevel",
 	"UnitExists",
 	"UnitFactionGroup",
 	"UnitGUID",
-	"UnitGetTotalAbsorbs",
 	"UnitGroupRolesAssigned",
 	"UnitHealth",
 	"UnitHealthMax",
 	"UnitInBattleground",
 	"UnitInParty",
 	"UnitInRaid",
 	"UnitInRange",
-	"UnitInVehicle",
 	"UnitIsConnected",
-	"UnitIsCorpse",
 	"UnitIsDead",
 	"UnitIsDeadOrGhost",
 	"UnitIsFeignDeath",
@@ -287,11 +199,5 @@ globals = {
 	"UnitIsVisible",
 	"UnitLevel",
 	"UnitName",
-	"UnitPlayerControlled",
-	"UnitPosition",
-	"UnitPower",
-	"UnitPowerMax",
 	"UnitRace",
-	"UnitSetRole",
-	"WorldFrame",
 }

libs/LibDialog-1.0/LibDialog-1.0.lua

@@ -20,11 +20,11 @@ local table = _G.table
 -- Library namespace.
 -----------------------------------------------------------------------
 local LibStub = _G.LibStub
-local MAJOR = "LibDialog-1.0"
+local MAJOR = "LibDialog-1.0n"
 
 _G.assert(LibStub, MAJOR .. " requires LibStub")
 
-local MINOR = 8 -- Should be manually increased
+local MINOR = 9 -- Should be manually increased
 local lib, oldminor = LibStub:NewLibrary(MAJOR, MINOR)
 
 if not lib then
@@ -124,6 +124,29 @@ local editbox_heap = lib.editbox_heap
 -----------------------------------------------------------------------
 -- Helper functions.
 -----------------------------------------------------------------------
+-- May 7th 2024, 1.15.2 and other clients still diverge on StaticPopup_DisplayedFrames / StaticPopup_HasDisplayedFrames
+-- so we still need both to find the last StaticPopup for anchoring
+local function _SetupAnchor(dialog)
+    local default_dialog
+    if _G.StaticPopup_DisplayedFrames then
+        default_dialog = _G.StaticPopup_DisplayedFrames[#_G.StaticPopup_DisplayedFrames]
+    elseif (_G.StaticPopup_HasDisplayedFrames and _G.StaticPopup_IsLastDisplayedFrame) then
+        if StaticPopup_HasDisplayedFrames() then
+            for idx = STATICPOPUP_NUMDIALOGS,1,-1 do
+                local test_dialog = _G["StaticPopup"..idx]
+                if StaticPopup_IsLastDisplayedFrame(test_dialog) then
+                    default_dialog = test_dialog
+                end
+            end
+        end
+    end
+    if default_dialog then
+        dialog:SetPoint("TOP", default_dialog, "BOTTOM", 0, 0)
+    else
+        dialog:SetPoint("TOP", _G.UIParent, "TOP", 0, -135)
+    end
+end
+
 local function _ProcessQueue()
     if #active_dialogs == MAX_DIALOGS then
         return
@@ -148,13 +171,7 @@ local function _RefreshDialogAnchors()
         current_dialog:ClearAllPoints()
 
         if index == 1 then
-            local default_dialog = _G.StaticPopup_DisplayedFrames[#_G.StaticPopup_DisplayedFrames]
-
-            if default_dialog then
-                current_dialog:SetPoint("TOP", default_dialog, "BOTTOM", 0, 0)
-            else
-                current_dialog:SetPoint("TOP", _G.UIParent, "TOP", 0, -135)
-            end
+            _SetupAnchor(current_dialog)
         else
             current_dialog:SetPoint("TOP", active_dialogs[index - 1], "BOTTOM", 0, 0)
         end
@@ -378,7 +395,11 @@ local function _AcquireCheckBox(parent, index)
     active_checkboxes[#active_checkboxes + 1] = checkbox
 
     checkbox:SetPoint("LEFT", 0, 0)
-    checkbox.text:SetText(parent.delegate.checkboxes[index].label or "")
+    if checkbox.Text then
+        checkbox.Text:SetText(parent.delegate.checkboxes[index].label or "")
+    elseif checkbox.text then
+        checkbox.text:SetText(parent.delegate.checkboxes[index].label or "")
+    end
     checkbox.container:SetParent(parent)
     checkbox:SetID(index)
     checkbox:SetChecked(CheckBox_GetValue(checkbox))
@@ -675,7 +696,12 @@ local function _BuildDialog(delegate, data)
         local max_string_width = 0
 
         for index = 1, #dialog.checkboxes do
-            local string_width = dialog.checkboxes[index].text:GetStringWidth()
+            local string_width = 0
+            if dialog.checkboxes[index].Text then
+                dialog.checkboxes[index].Text:GetStringWidth()
+            elseif dialog.checkboxes[index].text then
+                dialog.checkboxes[index].text:GetStringWidth()
+            end
 
             if string_width > max_string_width then
                 max_string_width = string_width
@@ -830,13 +856,7 @@ function lib:Spawn(reference, data)
     if #active_dialogs > 0 then
         dialog:SetPoint("TOP", active_dialogs[#active_dialogs], "BOTTOM", 0, 0)
     else
-        local default_dialog = _G.StaticPopup_DisplayedFrames[#_G.StaticPopup_DisplayedFrames]
-
-        if default_dialog then
-            dialog:SetPoint("TOP", default_dialog, "BOTTOM", 0, 0)
-        else
-            dialog:SetPoint("TOP", _G.UIParent, "TOP", 0, -135)
-        end
+        _SetupAnchor(dialog)
     end
     active_dialogs[#active_dialogs + 1] = dialog
     dialog:Show()

locales/frFR.lua

@@ -149,7 +149,7 @@ L["hideDead"] = "Cacher quand mort"
 L["hideOffline"] = "Cacher quand déconnecté"
 L["hideOutOfCombat"] = "Cacher quand hors de combat"
 L["hideOutOfRange"] = "Cacher quand hors de portée"
--- L["hideInGroupDesc"] = "Hide cooldowns in this type of group."
+L["hideInGroupDesc"] = "Cache les temps de recharge de ce type de groupe."
 L["hideInInstanceDesc"] = "Cache les temps de recharge dans ce type d'instance."
 L["hideRolesDesc"] = "Cache les temps de recharge des joueurs ayant ce rôle."
 L["hideGroupDesc"] = "Cache les temps de recharge des joueurs de ce groupe."
@@ -169,7 +169,7 @@ L["labelTextSettings"] = "Paramètre du texte du libellé"
 L["durationTextSettings"] = "Paramètres du texte de durée"
 L["useClassColor"] = "Couleur de classe"
 L["customColor"] = "Couleur personnalisée"
--- L["classColorBorder"] = "Class color borders"
+L["classColorBorder"] = "Bordures des couleurs de classe"
 L["backgroundColor"] = "Couleur de l'arrière-plan"
 L["useStatusColor"] = "Utiliser une couleur de statut"
 L["useStatusColorDesc"] = "Change la couleur de la barre quand un joueur est hors portée, mort ou hors-ligne."
@@ -248,8 +248,8 @@ L["lockMonitor"] = "Verrouiller le moniteur"
 L["battleResLockDesc"] = "Verrouille ou non le moniteur. Ceci masquera le texte d'en-tête, l'arrière-plan, et empêchera son déplacement."
 L["showMonitor"] = "Afficher le moniteur"
 L["battleResShowDesc"] = "Affiche ou cache le moniteur."
--- L["battleResAlwaysShow"] = "Always show"
--- L["battleResAlwaysShowDesc"] = "Show the display even when no class in the group can use a battle res."
+L["battleResAlwaysShow"] = "Toujours afficher"
+L["battleResAlwaysShowDesc"] = "Affiche le moniteur même si aucune classe du groupe ne peut utiliser de rez combat."
 
 -- Consumables Module
 L["consumables"] = "Vérif. des consommables"