.github/workflows/build-classic.yml

@@ -18,7 +18,7 @@ jobs:
 
     steps:
       - name: Checkout addon
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
 
     steps:
       - name: Checkout addon
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/pull_request.yml

@@ -8,7 +8,7 @@ jobs:
 
     steps:
       - name: Checkout addon
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Run luacheck
         uses: BigWigsMods/actions/luacheck@master

.luacheckrc

@@ -14,6 +14,11 @@ ignore = {
 	"432/self", -- Shadowing an upvalue argument
 }
 globals = {
+	-- Addons
+	"ElvUI",
+	"LibStub",
+	"Tukui",
+
 	-- wow std api
 	"abs",
 	"acos",
@@ -83,135 +88,72 @@ globals = {
 	"tremove",
 	"wipe",
 
-	-- framexml
-	"AuraUtil",
-	"CopyTable",
-	"getprinthandler",
-	"hash_SlashCmdList",
-	"setprinthandler",
-	"tContains",
-	"tDeleteItem",
-	"tInvert",
-	"tostringall",
-	"UIPanelWindows",
+	-- FrameXML
 	"CanOpenPanels",
+	"ChatTypeInfo",
+	"CopyTable",
+	"FriendsFrame",
+	"GameFontNormal",
+	"GameTooltip",
+	"GameTooltip_Hide",
 	"GetUIPanel",
 	"GetUIPanelWidth",
+	"SecondsToTime",
+	"SlashCmdList",
+	"UIPanelWindows",
+	"UIParent",
+	"tContains",
 
-	-- everything else
-	"AlertFrame",
+	-- API
 	"Ambiguate",
 	"BNGetFriendIndex",
 	"BNInviteFriend",
-	"BNIsSelf",
 	"BNSendWhisper",
-	"BasicMessageDialog",
-	"BossBanner",
+	"C_AddOns",
 	"C_BattleNet",
-	"C_CVar",
 	"C_ChatInfo",
-	"C_EncounterJournal",
-	"C_FriendList",
 	"C_GuildInfo",
+	"C_Item",
 	"C_Map",
 	"C_PaperDollInfo",
 	"C_PartyInfo",
-	"C_RaidLocks",
-	"C_Scenario",
 	"C_Spell",
 	"C_Timer",
-	"C_TradeSkillUI",
-	"C_UIWidgetManager",
-	"ChatFrame_ImportAllListsToHash",
-	"ChatTypeInfo",
-	"CheckInteractDistance",
-	"CinematicFrame_CancelCinematic",
-	"CollapseFactionHeader",
+	"C_UnitAuras",
 	"CombatLogGetCurrentEventInfo",
-	"CombatLog_String_GetIcon",
 	"CreateFrame",
 	"DemoteAssistant",
 	"DoReadyCheck",
-	"EJ_GetCreatureInfo",
 	"EJ_GetEncounterInfo",
-	"EJ_GetTierInfo",
-	"ElvUI",
-	"EnableAddOn",
-	"ExpandFactionHeader",
-	"FlashClientIcon",
-	"FriendsFrame",
-	"GameFontHighlight",
-	"GameFontNormal",
-	"GameTooltip",
-	"GameTooltip_Hide",
-	"GetAddOnDependencies",
-	"GetAddOnEnableState",
-	"GetAddOnInfo",
-	"GetAddOnMetadata",
-	"GetAddOnOptionalDependencies",
 	"GetAverageItemLevel",
 	"GetBattlefieldStatus",
 	"GetCVarBool",
 	"GetChannelDisplayInfo",
 	"GetChannelName",
-	"GetDetailedItemLevelInfo",
-	"GetDifficultyInfo",
-	"GetExpansionLevel",
-	"GetFactionInfo",
-	"GetFramesRegisteredForEvent",
 	"GetGuildInfo",
 	"GetGuildRosterInfo",
 	"GetInstanceInfo",
 	"GetInventoryItemLink",
-	"GetInventoryItemQuality",
-	"GetItemCount",
-	"GetItemSpell",
-	"GetItemStats",
 	"GetLFGMode",
 	"GetLocale",
 	"GetMaxBattlefieldID",
 	"GetMaxLevelForLatestExpansion",
-	"GetNumAddOns",
 	"GetNumDisplayChannels",
-	"GetNumFactions",
 	"GetNumGroupMembers",
 	"GetNumGuildMembers",
 	"GetNumSubgroupMembers",
-	"GetPartyAssignment",
-	"GetPlayerFacing",
-	"GetProfessionInfo",
-	"GetProfessions",
 	"GetRaidDifficultyID",
 	"GetRaidRosterInfo",
 	"GetRaidTargetIndex",
 	"GetReadyCheckStatus",
 	"GetReadyCheckTimeLeft",
 	"GetRealZoneText",
 	"GetRealmName",
-	"GetSpecialization",
-	"GetSpecializationInfoByID",
-	"GetSpecializationRole",
 	"GetSpecializationRoleByID",
-	"GetSpellBookItemName",
-	"GetSpellBookItemTexture",
-	"GetSpellCharges",
-	"GetSpellCooldown",
-	"GetSpellDescription",
-	"GetSpellInfo",
-	"GetSpellLink",
-	"GetSpellTabInfo",
-	"GetSpellTexture",
-	"GetSubZoneText",
-	"GetTexCoordsForRole",
-	"GetTexCoordsForRoleSmallCircle",
 	"GetTime",
-	"GetTrackedAchievements",
 	"GuildControlGetNumRanks",
 	"GuildControlGetRankName",
 	"InCombatLockdown",
-	"IsAddOnLoadOnDemand",
-	"IsAddOnLoaded",
-	"IsAltKeyDown",
 	"IsControlKeyDown",
 	"IsEncounterInProgress",
 	"IsEveryoneAssistant",
@@ -220,60 +162,31 @@ globals = {
 	"IsInGuild",
 	"IsInInstance",
 	"IsInRaid",
-	"IsItemInRange",
-	"IsLoggedIn",
-	"IsPartyLFG",
 	"IsShiftKeyDown",
-	"IsSpellKnown",
-	"IsTestBuild",
-	"LFGDungeonReadyPopup",
-	"LibStub",
-	"LoadAddOn",
-	"LoggingCombat",
-	"MovieFrame",
-	"ObjectiveTrackerFrame",
 	"PlaySound",
-	"PlaySoundFile",
-	"PlayerHasToy",
 	"PromoteToAssistant",
-	"RaidBossEmoteFrame",
-	"RaidNotice_AddMessage",
-	"RaidWarningFrame",
-	"RolePollPopup",
-	"SecondsToTime",
 	"SendChatMessage",
 	"SetEveryoneIsAssistant",
 	"SetPortraitToTexture",
 	"SetRaidDifficulties",
-	"SetRaidTarget",
-	"SlashCmdList",
 	"StopSound",
-	"Tukui",
-	"UIErrorsFrame",
-	"UIParent",
 	"UninviteUnit",
 	"UnitAffectingCombat",
-	"UnitAura",
-	"UnitCanAttack",
 	"UnitCastingInfo",
 	"UnitChannelInfo",
 	"UnitClass",
-	"UnitDetailedThreatSituation",
-	"UnitEffectiveLevel",
+	"UnitClassBase",
 	"UnitExists",
 	"UnitFactionGroup",
 	"UnitGUID",
-	"UnitGetTotalAbsorbs",
 	"UnitGroupRolesAssigned",
 	"UnitHealth",
 	"UnitHealthMax",
 	"UnitInBattleground",
 	"UnitInParty",
 	"UnitInRaid",
 	"UnitInRange",
-	"UnitInVehicle",
 	"UnitIsConnected",
-	"UnitIsCorpse",
 	"UnitIsDead",
 	"UnitIsDeadOrGhost",
 	"UnitIsFeignDeath",
@@ -286,11 +199,5 @@ globals = {
 	"UnitIsVisible",
 	"UnitLevel",
 	"UnitName",
-	"UnitPlayerControlled",
-	"UnitPosition",
-	"UnitPower",
-	"UnitPowerMax",
 	"UnitRace",
-	"UnitSetRole",
-	"WorldFrame",
 }

libs/CallbackHandler-1.0/CallbackHandler-1.0.lua

@@ -1,32 +1,22 @@
---[[ $Id: CallbackHandler-1.0.lua 1186 2018-07-21 14:19:18Z nevcairiel $ ]]
-local MAJOR, MINOR = "CallbackHandler-1.0", 7
+--[[ $Id: CallbackHandler-1.0.lua 26 2022-12-12 15:09:39Z nevcairiel $ ]]
+local MAJOR, MINOR = "CallbackHandler-1.0", 8
 local CallbackHandler = LibStub:NewLibrary(MAJOR, MINOR)
 
 if not CallbackHandler then return end -- No upgrade needed
 
 local meta = {__index = function(tbl, key) tbl[key] = {} return tbl[key] end}
 
 -- Lua APIs
-local tconcat = table.concat
-local assert, error, loadstring = assert, error, loadstring
-local setmetatable, rawset, rawget = setmetatable, rawset, rawget
+local securecallfunction, error = securecallfunction, error
+local setmetatable, rawget = setmetatable, rawget
 local next, select, pairs, type, tostring = next, select, pairs, type, tostring
 
--- Global vars/functions that we don't upvalue since they might get hooked, or upgraded
--- List them here for Mikk's FindGlobals script
--- GLOBALS: geterrorhandler
-
-local xpcall = xpcall
-
-local function errorhandler(err)
-	return geterrorhandler()(err)
-end
 
 local function Dispatch(handlers, ...)
 	local index, method = next(handlers)
 	if not method then return end
 	repeat
-		xpcall(method, errorhandler, ...)
+		securecallfunction(method, ...)
 		index, method = next(handlers, index)
 	until not method
 end
@@ -39,7 +29,7 @@ end
 --   UnregisterName    - name of the callback unregistration API, default "UnregisterCallback"
 --   UnregisterAllName - name of the API to unregister all callbacks, default "UnregisterAllCallbacks". false == don't publish this API.
 
-function CallbackHandler:New(target, RegisterName, UnregisterName, UnregisterAllName)
+function CallbackHandler.New(_self, target, RegisterName, UnregisterName, UnregisterAllName)
 
 	RegisterName = RegisterName or "RegisterCallback"
 	UnregisterName = UnregisterName or "UnregisterCallback"
@@ -67,13 +57,13 @@ function CallbackHandler:New(target, RegisterName, UnregisterName, UnregisterAll
 
 		if registry.insertQueue and oldrecurse==0 then
 			-- Something in one of our callbacks wanted to register more callbacks; they got queued
-			for eventname,callbacks in pairs(registry.insertQueue) do
-				local first = not rawget(events, eventname) or not next(events[eventname])	-- test for empty before. not test for one member after. that one member may have been overwritten.
-				for self,func in pairs(callbacks) do
-					events[eventname][self] = func
+			for event,callbacks in pairs(registry.insertQueue) do
+				local first = not rawget(events, event) or not next(events[event])	-- test for empty before. not test for one member after. that one member may have been overwritten.
+				for object,func in pairs(callbacks) do
+					events[event][object] = func
 					-- fire OnUsed callback?
 					if first and registry.OnUsed then
-						registry.OnUsed(registry, target, eventname)
+						registry.OnUsed(registry, target, event)
 						first = nil
 					end
 				end