-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise snapshot feature copy #132
Comments
here's the background: Sjors pointed out that the copy in snapshot section is inaccurate:
His directional suggestion was:
Christoph provided his rationale, summarised roughly in:
I sympathise with both of these views, so I provided some context on the existing copy being the way it is: maintaining the mental model that's established by prior copy. But I also suggested some potential changes to the copy in line with *Sjor's suggested approach (see comment below). |
Quoting myself below, short-circuited with my view that current copy is not egregious in any way, and can be retained in the interest of time.
edit: fixed quotation level |
Hm, what do you think about avoiding the details around transactions and focusing on the balance?
|
Oh did I miss this from your previous comments? Anyway, balance is a closer proxy for the UTXO set than transactions, so if we can use balance-coded terminology & copy to build a mental model instead of simply being vague, I might like that better. I don't think the UTXO snapshot contains any transaction information per se, so dunno about the "transactions that make up that balance" part . IIRC you start with an assumed UTXO set (as of a certain block height) and start downloading the transactions so that you can update the UTXO set accordingly all the way up to the chain tip. |
There's a thread (make sure to read this) in a dev PR, related to the copy used in the snapshot feature, that has gotten somewhat long, that I'd like to hereby extract from that PR and turn into a separate discussions.
I suggest we resolve this here and in design first. Once we're happy, we can then create a new PR with those tweaks.
I'll keep this description short. I still need to catch up with the latest (longer) comment and will do so in a reply. But feel free to take it away.
The text was updated successfully, but these errors were encountered: