Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded Qt.QMouseEvent with configurable hotkeys.ini ones #3

Open
BluABK opened this issue Sep 1, 2018 · 2 comments
Open

Replace hardcoded Qt.QMouseEvent with configurable hotkeys.ini ones #3

BluABK opened this issue Sep 1, 2018 · 2 comments
Labels
configuration Issue is related to config files and/or its GUI frontend good first issue Good for newcomers gui optimizable hardcode Hardcoded properties that can be made configurable/dynamic

Comments

@BluABK
Copy link
Owner

BluABK commented Sep 1, 2018

Currently all mouse events/hotkeys are hardcoded.

This mostly concerns GridViews like SubfeedView and PlayView:

    def mousePressEvent(self, QMouseEvent):  # FIXME: Make mouse hotkeys based on hotkeys.ini
        """
        Override mousePressEvent to support mouse button actions
        :param QMouseEvent:
        :return:
        """
        if QMouseEvent.button() == Qt.MidButton:
            self.decrease_prio()
        elif QMouseEvent.button() == Qt.LeftButton and QApplication.keyboardModifiers() == Qt.ControlModifier:
            self.decrease_prio()
        elif QMouseEvent.button() == Qt.LeftButton and QApplication.keyboardModifiers() == Qt.AltModifier:
            self.mark_discarded()
        elif QMouseEvent.button() == Qt.LeftButton and QApplication.keyboardModifiers() == Qt.ShiftModifier:
            self.config_play_video(self.video.vid_path, self.get_default_player(), mark_watched=False)
        elif QMouseEvent.button() == Qt.LeftButton:
            self.config_play_video(self.video.vid_path, self.get_default_player())
@BluABK BluABK added the optimizable hardcode Hardcoded properties that can be made configurable/dynamic label Sep 1, 2018
@BluABK BluABK self-assigned this Sep 1, 2018
@BluABK BluABK added Qt5 and removed Qt5 labels Sep 1, 2018
@BluABK BluABK mentioned this issue Sep 3, 2018
Open
@BluABK BluABK added gui configuration Issue is related to config files and/or its GUI frontend labels Sep 3, 2018
@BluABK
Copy link
Owner Author

BluABK commented Sep 3, 2018

Related issues: #3 and #15.

@BluABK BluABK added the good first issue Good for newcomers label Sep 3, 2018
@BluABK BluABK removed their assignment Sep 3, 2018
@BluABK
Copy link
Owner Author

BluABK commented Mar 31, 2019

Hotfixed for Subfeed View in commit 3111c83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
configuration Issue is related to config files and/or its GUI frontend good first issue Good for newcomers gui optimizable hardcode Hardcoded properties that can be made configurable/dynamic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BluABK