Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey test Crout vs. Eigen. #1469

Open
1uc opened this issue Sep 25, 2024 · 0 comments
Open

Fix flakey test Crout vs. Eigen. #1469

1uc opened this issue Sep 25, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Sep 25, 2024

We're occasionally seeing:

Filters: "Scenario: Compare Crout solver with Eigen"
Randomness seeded to: 370099071
eigen_x_ColMajor vs crout_x_ColMajor (issue) / seed = 665289716

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
testcrout is a Catch2 v3.5.3 host application.
Run with -? for options

-------------------------------------------------------------------------------
Scenario: Compare Crout solver with Eigen
      Given: crout (double)
       Then: run tests & compare
-------------------------------------------------------------------------------
../test/unit/crout/crout.cpp:129
...............................................................................

../test/unit/crout/crout.cpp:130: FAILED:
  REQUIRE( test )
with expansion:
  false

eigen_timing [ms] : 32.2796
crout_timing [ms] : 34.7109
===============================================================================
test cases: 1 | 1 failed
assertions: 1 | 1 failed

This is likely due to a bug in the test, e.g. using random numbers. This needs to be made investigated and made to {fail,not fail} deterministically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant