Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Colour for threat on cotank #36

Open
argium opened this issue Nov 3, 2024 · 3 comments
Open

Feature Request: Colour for threat on cotank #36

argium opened this issue Nov 3, 2024 · 3 comments

Comments

@argium
Copy link

argium commented Nov 3, 2024

Threat colours only support red and green so if an NPC is targeting another tank (which requires no intervention, like green), it's marked as red instead of something else like blue.

@argium argium changed the title Feature Request Feature Request: Colour for threat on cotank Nov 3, 2024
@Bodify
Copy link
Owner

Bodify commented Nov 3, 2024

This has been requested a few times before. My focus is on PvP though and other more general features that fits both PvP and PvE. I do want to add this though but when I'll find the time I'm not sure, can be awhile I'm afraid.

@argium
Copy link
Author

argium commented Nov 5, 2024

For pvp, that explains quite a lot of the features you've added. Healer and execute icons are fantastic.

On my request: for what it's worth, the quality of life value for raiding is very high and would certainly be valuable to anyone tanking. The performance impact of both Plater and Threat Plates is severe so I think there'd be considerable interest in a lightweight name plate addon such as yours. If it's straightforward enough it might be something that I can submit a PR for.

@Bodify
Copy link
Owner

Bodify commented Nov 5, 2024

My code is quite messy, poor and straight up backwards. I updated the github with the most recent changes. I had forgotten about it. If you want to make an attempt be my guest, it would be lovely, but be aware that it might be hell working conditions lol. I'm no programmer so last time I attempted to accept a PR I messed things up a lot but solved it with my own... methods 😭As stated at the top of BetterBlizzPlates.lua:
-- I did not know what a variable was when I started. I know a little bit more now and I am so sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants