Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.5 #46

Merged
merged 41 commits into from
Feb 19, 2025
Merged

Release 2.1.5 #46

merged 41 commits into from
Feb 19, 2025

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Feb 18, 2025

Critical checks

  • Is the version number correct?

  • Does the build pass?


Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots
  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...


QC Report

  • Does it include a QC Report?

API conventions

  • Follows API convention

zsigmas and others added 7 commits January 28, 2025 18:11
Co-authored-by: ml-ebs-ext <[email protected]>
Co-authored-by: ml-ebs-ext <[email protected]>
Co-authored-by: ml-ebs-ext <[email protected]>
…ers-and-optional-feature

42 make dataset filters and optional feature
* When data.frames and not tibbles were used labels were lost
* Now we explicitly copy labels when filtering
* We also include a new testing module
* Include a set of tests for the labels
…ccidentally-removed-with-the-new-filter-strateg

39 some labels are accidentally removed with the new filter strateg
@zsigmas zsigmas added this to the 2.1.5 milestone Feb 18, 2025
@zsigmas zsigmas marked this pull request as ready for review February 18, 2025 10:10
@zsigmas zsigmas requested a review from a team as a code owner February 18, 2025 10:11
@zsigmas zsigmas requested review from mattkorb and iglauss February 18, 2025 10:11
zsigmas and others added 3 commits February 19, 2025 12:21
Co-authored-by: Korbinian Matthias <[email protected]>
Co-authored-by: Korbinian Matthias <[email protected]>
Co-authored-by: Isabel Glauß <[email protected]>
Co-authored-by: Korbinian Matthias <[email protected]>
@zsigmas zsigmas merged commit c4afe54 into main Feb 19, 2025
10 checks passed
@zsigmas zsigmas deleted the dev branch February 19, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants