Feat/exclude qc from articles #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DONT REVIEW / APPROVE / MERGE THIS THING UNTIL FURTHER NOTICE)
Running
pkgdown::build_site()twice does the trick but it would potentially be slow for packages with a long reference.That's why we run
pkgdown::init()+pkgdown::build_article('qc').Sadly, building that article requires that the package is installed because of a
system.file()call inside ofval_report_child.Rmd.Sadlier, there is no way of telling
pkgdownto do a dummy package installation throughpkgdown::build_article(...), so we go ahead and just do a regulardevtools::install()of the package.Sadliest, since each rendered page has its own independent header, when you visit the Changelog section, the dropdown still includes the offending QC link because the file was there at the time of rendering:
I'm still doubting I should PR these changes...