Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clonalCompare chain argument #476

Closed
ncborcherding opened this issue Feb 7, 2025 · 2 comments
Closed

clonalCompare chain argument #476

ncborcherding opened this issue Feb 7, 2025 · 2 comments
Assignees

Comments

@ncborcherding
Copy link
Member

Per #475

Selecting an individual TRB chain in clonalCompare creates an error:

combined.TCR <- combineTCR(contig_list, 
                           samples = c("P17B", "P17L", "P18B", "P18L", 
                                       "P19B","P19L", "P20B", "P20L"))
   
clonalCompare(combined.TCR,
              chain = "TRB")     

Error: chain is not in c("both", "TRA", "TRG", "IGH", "IGL")

@ncborcherding ncborcherding self-assigned this Feb 7, 2025
ncborcherding added a commit that referenced this issue Feb 8, 2025
Expanded assertthat for TRB and TRD per issue per issue #476
@ncborcherding
Copy link
Member Author

There was an assert that statement that in did not include all of the chains - now fixed:

is.string(chain), chain %in% c("both", "TRA", "TRB", "TRG", "TRD", "IGH", "IGL")

Here is the updated example:

combined.TCR <- combineTCR(contig_list, 
                           samples = c("P17B", "P17L", "P18B", "P18L", 
                                       "P19B","P19L", "P20B", "P20L"))
   
clonalCompare(combined.TCR,
              chain = "TRB")  

clonalCompare(combined.TCR[1:2],
                         chain = "TRB", 
                         top.clones = 10)  
Image

@airabiotenor
Copy link

Hi @ncborcherding is it possible to add "IGK" as well? Or is there a reason it is excluded as a chain option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants