Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field values containing slash character are split #1073

Closed
lars-dreier opened this issue Mar 31, 2022 · 4 comments
Closed

Field values containing slash character are split #1073

lars-dreier opened this issue Mar 31, 2022 · 4 comments
Assignees

Comments

@lars-dreier
Copy link

Bug description
Could reproduce with genre and track artist fields.
If a field value contains a slash, without trailing spaces, the string is split.
Especially troublesome with track artists (e.g. "AC/DC")

Expected behavior
No value should be split by slash character

@lars-dreier lars-dreier changed the title Tag Values containing slash character are split Field values containing slash character are split Mar 31, 2022
@Borewit
Copy link
Owner

Borewit commented Apr 1, 2022

Can you provide a sample file @AdmiralToast?

@Borewit Borewit added the user input required Need more information to reproduce or understand the issue label Apr 1, 2022
@lars-dreier
Copy link
Author

Sure thing!

I also checked with flac (vorbis comment) file where it doesn't happen (i.e. everything is parsed as a single string).
But with Mp3 (ID3v2.3) I could see that the following fields get split:

  • artist (artist field itself contains part before slash, artists array contains both parts as single elements in array)
  • composer
  • genre

I used some dummy sample file so I don't commit copyright infringement but the tags are set so you can easily reproduce.
sample2.mp3.zip

@Borewit
Copy link
Owner

Borewit commented Apr 2, 2022

Duplicate of issue #52
Another similar issue: beetbox/mediafile#21

The separation between artists decoded using '/' is in line with the specification: https://id3.org/id3v2.3.0#line-455

So "AC/DC" is an artist name you cannot specify without resulting in this kind of misinterpretations.

If you use the ID3v2.4 instead, you no longer have that constraint.

@Borewit Borewit closed this as completed Apr 2, 2022
@Borewit Borewit self-assigned this Apr 2, 2022
@Borewit Borewit removed the user input required Need more information to reproduce or understand the issue label Apr 2, 2022
@lars-dreier
Copy link
Author

Thanks for the reply, especially the specs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants