Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't depricate time sensors #1174

Open
1 of 2 tasks
MJWMJW2 opened this issue Jan 12, 2025 · 1 comment
Open
1 of 2 tasks

Please don't depricate time sensors #1174

MJWMJW2 opened this issue Jan 12, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@MJWMJW2
Copy link

MJWMJW2 commented Jan 12, 2025

Describe the feature

Please consider to not deprecate the existing entities. time.octopus_energy_a_1a111111_intelligent_target_time allows input of time which is valid which the select does not. It is perfectly valid, for example, to select a target time of 10:59 should one wish to. Should this be done through existing sensor, or another API call, this then leaves the new sensor not able to display a value. Removing it would remove the ability to set a number of valid times which may be desired.

The target time sensor (defaults to time.octopus_energy_a_1a111111_intelligent_target_time) has been deprecated in favour of a select based sensor (select.octopus_energy_a_1a111111_intelligent_target_time) to make it easier to select a valid time. This old sensor will be removed in a future release.

image
image

Expected behaviour

Ability to select / determine valid entries.
Ability for sensor to correctly detect the value set via octopus API by other means

Use Case

It may be desirable to set a value not aligned with a 30 minute window. For example if a depart time is set for 09:15, it is desirable to have the car charge to that time specifically so that the batteries are warmed.

Confirmation

  • By submitting this feature request, you agree that you have read the documentation and confirmed it does not already exist
  • I am willing/able to help contribute to the solution of this feature
@MJWMJW2 MJWMJW2 added the enhancement New feature or request label Jan 12, 2025
@BottlecapDave
Copy link
Owner

My response on the matter - #1079 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants