Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Remove Additional Items in Houses #303

Open
TwilightPSN opened this issue Jan 10, 2025 · 7 comments
Open

[Enhancement]: Remove Additional Items in Houses #303

TwilightPSN opened this issue Jan 10, 2025 · 7 comments
Assignees

Comments

@TwilightPSN
Copy link

Minecraft Version

1.20.1

Forge Version

47.3.0

Mod Version

1.10.0.1

Details

Currently if you disable the furances/chests from the housesthe item frames from the chests stay, as do the hoppers. Could these possible also have a toggle to be removed when these items are disabled?

@Brian-Wuest
Copy link
Owner

You know I don't know why this hasn't been brought up before. It's a great idea!

For the item frames I am thinking that they should just not generate since they won't have anything to attach to and just fall off anyways in that situation (I.E. not providing an option for that).

Not all of the houses have hoppers so I will have to look at them and add the option for the ones that do.

Love the idea.

@Brian-Wuest Brian-Wuest self-assigned this Jan 10, 2025
@Brian-Wuest
Copy link
Owner

Note: May be a bit until I get to this. Trying to troubleshoot some graphical issues with the mod currently that is game-breaking when using shader packs. There's a long discussion in the Discord chat about it. Hopefully it gets narrowed down soon to what is causing the issue so I can fix it.

@TwilightPSN
Copy link
Author

I've started to develope a new modpack and making an expert pack where things are gated to the idea came to me. I'm usine the prefab houses as I hate seeing people live in holes in a wall LOL

@Brian-Wuest Brian-Wuest changed the title [Enhancement]: Remove Additional Itesm in Houses [Enhancement]: Remove Additional Items in Houses Jan 21, 2025
@Brian-Wuest
Copy link
Owner

Hey, finally got back to this, sorry for the wait.

However, I tried looking through ALL of the houses, and the only ones which have item frames in-front of chests are in the Advanced Houses item.

This item doesn't respect the "Do Not Add Chests to the Build" configuration option and never has, only the regular and Improved Houses items do. I could not find any Item Frames in-front of any chests in those builds (Basic and Improved).

If you could point me to an example of what you were seeing it would be greatly appreciated!

Thank you!

@TwilightPSN
Copy link
Author

From when i used it on 1.20.1 it actually did remove the chests on those houses which left the item frames all over the ground. Not sure if that was intended

@Brian-Wuest
Copy link
Owner

Hmmm, maybe it was because I was in creative mode. I will try in survival. When I am done with work this evening.

@Brian-Wuest
Copy link
Owner

Just tried it with the Workshop which has actual chests and not just barrels and the chests were not removed.

I un-checked the option to "Add Chests" in the mod configuration and re-loaded the world to make sure the configuration change "stuck" and then generated the building and this is the result. The chests still stayed like I thought.

You will have to show me which build you were talking about specifically because I don't know which one was causing the issue and the ones which could have caused the issue (chests with item frames) don't have the ability to be generated without the chests unless another mod interfered with Prefab which entirely possible.

Screenshot showing inside of Workshop
Image

Screenshot showing mod options.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants