Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.3 is a breaking change #37

Open
m90 opened this issue Mar 29, 2020 · 1 comment
Open

v2.0.3 is a breaking change #37

m90 opened this issue Mar 29, 2020 · 1 comment

Comments

@m90
Copy link

m90 commented Mar 29, 2020

v2.0.3 includes asn1.js@5 when v2.0.2 would include asn1.js@4

This introduces a breaking change for node-jwk-to-pem as well as the code in the dependency is now ES6 (i.e. it uses const which makes older build pipelines choke) when previously it would be using ES5 syntax only.

See: indutny/asn1.js#99 for the same issue happening with asn1.js itself.
@m90
Copy link
Author

m90 commented Mar 29, 2020 •
edited
Loading

Other related issues I could find:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m90