Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systems Refactor: LoadsSystem, @systems_map, etc. #100

Open
corymosiman12 opened this issue Dec 16, 2020 · 0 comments
Open

Systems Refactor: LoadsSystem, @systems_map, etc. #100

corymosiman12 opened this issue Dec 16, 2020 · 0 comments

Comments

@corymosiman12
Copy link
Contributor

As part of the refactor to address #98, the Facility.@systems_map attribute was introduced. Previously, systems weren't well connected to the premises that they served. Initial testing was introduced in the Facility Spec (it mainly has to do with ensuring data is correctly imported from xml, not that the system information is applied correctly on simulation):

RSpec.describe 'Facility Systems Mapping' do

The testing still falls short. Known issues:

  • A LoadsSystem does not get generated in the event systems are found. This leads to downstream errors when a loads system doesn't exist.
  • LoadsSystem has a very 'OpenStudio' view of what this means. Includes information for: occupancy, internal loads, schedules, elevator. Is this what we want?
  • The @systems_map doesn't get used as effectively as it could

A refactor of these should be done to better align BSync schema with OpenStudio concepts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant