Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageObject: properties should be refactored #15

Open
benrussill opened this issue Mar 16, 2022 · 0 comments
Open

StorageObject: properties should be refactored #15

benrussill opened this issue Mar 16, 2022 · 0 comments

Comments

@benrussill
Copy link

benrussill commented Mar 16, 2022 •
edited
Loading

public long Length => should be ulong
public int ServerId => uint
public long StorageZoneId => ulong

In general, you should not be doing primitive obsession and be using "value objects", ie. for path, zonename, etc

Treating Primitive Obsession with Value Objects (Nick Chapsas)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benrussill