Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no shutdown for the server #9

Open
smillidge opened this issue Jul 1, 2013 · 4 comments
Open

There is no shutdown for the server #9

smillidge opened this issue Jul 1, 2013 · 4 comments
Assignees
@jerrinot
Labels
enhancement
Milestone
1.0.0.alpha

Comments

@smillidge
Copy link
Member

We need to implement a shutdown method that closes the server and closes all the netty resources
@ghost ghost assigned jerrinot Jul 1, 2013
jerrinot added a commit that referenced this issue Jul 2, 2013
@jerrinot
#9, shutdown method
09d0be0
@jerrinot
Copy link
Contributor

jerrinot commented Jul 2, 2013

I added the shutdown method. It should be tested to corner cases.

@smillidge
Copy link
Member Author

I thought you had to create a ChannelGroup and track and close all Channels before doing the releaseExternalResources?

@jerrinot
Copy link
Contributor

jerrinot commented Jul 2, 2013

You are right. It's not that easy. I knew why I wasn't closing this issue! :)

@smillidge
Copy link
Member Author

I started it last weekend but have blown mine away now to synch up with the master.

If I remember we need to track Channel creation by tracking Channel opens in MemcachedResponseHandler and adding the channels to a Channel Group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerrinot jerrinot

Labels
enhancement
Projects
None yet
Milestone
1.0.0.alpha
Development

No branches or pull requests
2 participants
@jerrinot @smillidge