Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMZ-export environment file installs CAREamics from github not pypi #385

Closed
melisande-c opened this issue Feb 3, 2025 · 0 comments · Fixed by #395
Closed

BMZ-export environment file installs CAREamics from github not pypi #385

melisande-c opened this issue Feb 3, 2025 · 0 comments · Fixed by #395
Assignees
Labels
bug Something isn't working
Milestone

Comments

@melisande-c
Copy link
Member

melisande-c commented Feb 3, 2025

The environment file that is created during the BMZ export installs CAREamics from github and not pypi. The current environment file will install CAREamics from the main branch, which may not be compatible with the exported config file and/or model anymore. The environment file should install the version of CAREamics the model was created with.

See environment file text that is created below.

env = (
f"name: careamics\n"
f"dependencies:\n"
f" - python=3.10\n"
f" - pytorch={pytorch_version}\n"
f" - torchvision={torchvision_version}\n"
f" - pip\n"
f" - pip:\n"
f" - git+https://github.com/CAREamics/careamics.git\n"
)

Suggested change

    f"- careamics={__version__}"
@melisande-c melisande-c added the bug Something isn't working label Feb 3, 2025
@jdeschamps jdeschamps added this to v0.1.0 Feb 3, 2025
@jdeschamps jdeschamps moved this to Todo in v0.1.0 Feb 3, 2025
@jdeschamps jdeschamps added this to the v0.1.0 milestone Feb 3, 2025
@melisande-c melisande-c changed the title BMZ-export environment file installs CAREamics from git not pypi BMZ-export environment file installs CAREamics from github not pypi Feb 3, 2025
@jdeschamps jdeschamps self-assigned this Feb 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in v0.1.0 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants