Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IssueTablesComponent #1315

Open
yucongkoo opened this issue Feb 8, 2025 · 1 comment
Open

Refactor IssueTablesComponent #1315

yucongkoo opened this issue Feb 8, 2025 · 1 comment
Labels
category.Enhancement an enhancement to an existing feature difficulty.Easy suitable for beginners good first issue p.Low low value, can be delayed indefinitely

Comments

@yucongkoo
Copy link
Contributor

While implementing the new UI for bug reporting phase in #1312, I noticed some places that I could be further improved in terms of code quality, mainly the following 2 aspects:

  • Duplication of code between deleteIssue and undeleteIssue, they are essentially performing the same actions, but in reverse directions, hence the code is highly duplicated.
  • There are 2 separate lists issuesPendingDeletion and issuesPendingRestore, which is used for displaying the loading icon (instead of the delete/restore icon), we can actually merge these 2 lists into a single list (maybe issuesPendingAction?) instead and display the loading icon (and hide the delete/restore icon) based on this list
  • There is a lot of conditional logic in the issue-tables.component.html file, we should probably move these logic into the issue-tables.component.ts file instead. See the *ngIf=...
Image
@yucongkoo yucongkoo added category.Enhancement an enhancement to an existing feature difficulty.Easy suitable for beginners p.Low low value, can be delayed indefinitely labels Feb 8, 2025
@Arif-Khalid
Copy link
Contributor

Arif-Khalid commented Feb 9, 2025

This is a good enhancement which I agree with. Labels assigned are appropriate.
If the component isn't inherently refactored by #1309 , I would recommend setting this issue as a good-first-issue for new contributors and leaving it for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category.Enhancement an enhancement to an existing feature difficulty.Easy suitable for beginners good first issue p.Low low value, can be delayed indefinitely
Projects
None yet
Development

No branches or pull requests

2 participants