Refactor IssueTablesComponent #1315
Labels
category.Enhancement
an enhancement to an existing feature
difficulty.Easy
suitable for beginners
good first issue
p.Low
low value, can be delayed indefinitely
While implementing the new UI for bug reporting phase in #1312, I noticed some places that I could be further improved in terms of code quality, mainly the following 2 aspects:
deleteIssue
andundeleteIssue
, they are essentially performing the same actions, but in reverse directions, hence the code is highly duplicated.issuesPendingDeletion
andissuesPendingRestore
, which is used for displaying the loading icon (instead of the delete/restore icon), we can actually merge these 2 lists into a single list (maybeissuesPendingAction
?) instead and display the loading icon (and hide the delete/restore icon) based on this listissue-tables.component.html
file, we should probably move these logic into theissue-tables.component.ts
file instead. See the*ngIf=...
The text was updated successfully, but these errors were encountered: