Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likely wrong type #504

Closed
tpadioleau opened this issue Jun 26, 2024 · 2 comments · Fixed by #505
Closed

Likely wrong type #504

tpadioleau opened this issue Jun 26, 2024 · 2 comments · Fixed by #505
Assignees
Labels
bug Something isn't working

Comments

@tpadioleau
Copy link
Member

@thierryantoun did you really mean int or double for the bounds parameters of
generate_random_vector ?

@thierryantoun
Copy link
Member

thierryantoun commented Jun 26, 2024

As this function was only meant for this example, I put it as int but in general it would be a double I guess. Do you want me to change it ?

@tpadioleau
Copy link
Member Author

Yes please do. The parameters that are given are of type double, we cannot implicitly round the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants