Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible problem in ice_restoring if hbar=hin_min or hin_max then restoring to zero #972

Open
JFLemieux73 opened this issue Sep 5, 2024 · 1 comment

Comments

@JFLemieux73
Copy link
Contributor

JFLemieux73 commented Sep 5, 2024

The code is currently like this:

!-----------------------------------------------------------------
! initial area and thickness in ice-occupied restoring cells
!-----------------------------------------------------------------

  hbar = c2  ! initial ice thickness
  hsno_init = 0.20_dbl_kind ! initial snow thickness (m)
  do n = 1, ncat
     hinit(n) = c0
     ainit(n) = c0
     if (hbar > hin_max(n-1) .and. hbar < hin_max(n)) then
        hinit(n) = hbar
        ainit(n) = 0.95_dbl_kind ! initial ice concentration
     endif
  enddo

We should have instead:

  if (hbar >= hin_max(n-1) .and. hbar < hin_max(n)) then
@apcraig
Copy link
Contributor

apcraig commented Oct 4, 2024

FYI, this is in /cicecore/cicedyn/infrastructure/ice_restoring.F90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants