Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First timestep of bcm array during MT not Eddington limited #571

Open
michaelzevin opened this issue Sep 12, 2022 · 0 comments
Open

First timestep of bcm array during MT not Eddington limited #571

michaelzevin opened this issue Sep 12, 2022 · 0 comments
Labels

Comments

@michaelzevin
Copy link
Collaborator

michaelzevin commented Sep 12, 2022

Though we seemed to have fixed all the edge cases that were allowing for super-Eddington accretion even when eddlim=1 is set, it seems like the first write to the bcm array during the mass transfer phase doesn't obey the Eddington limit. This is probably due to some writebcm call that happens before the mass transfer limit is imposed.

Below are a few example tracks that show this behavior, both for the "old" Hurley+2022 prescription for applying the Eddington limit for BHs as well as the "new" method derived from Bardeen1970 and Marchant+2017, which is implemented in PR #570. Initial conditions for these systems are also attached.

download

super_edd_initCs.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant