You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there any reason vsomeip is attempting to change the type? I think sticking to the platform defined type is much safer. I've also prepared #561 to use the types more consistently throughout vsomeip. I haven't removed the lines in primitive_types.hpp yet but will probably do so - I just wanted to first ask if there was a reason.
The text was updated successfully, but these errors were encountered:
Thanks for the reply. I wish I had have known about that PR while it was under development. My group has been maintaining QNX ports for a few years now and likely had a lot to contribute.
About the uid being a bad type though, how to you suggest I pursue this? Just open a PR and cite #447 ?
You can still contribute to the QNX support and vSomeIP, if you have suggestions to improve the current QNX implementation please create a PR with the changes.
Regarding the uid stuff, is probably easier if you update your PR #561, or close that one and create a new one.
I see that 3.4.9 has started integrating QNX 7.1 support. The source seems to be specifiying [wrong] types for the uid/gid though. For instance, in
vsomeip/interface/vsomeip/primitive_types.hpp
Lines 59 to 65 in 70d59ed
This type is defined by QNX already in
$QNX_TARGET/usr/include/sys/target_nto.h
, for me it's:There are then many includes (
stat.h
,types.h
, etc) that do:By contrast, capicxx-core-runtime does this properly: https://github.com/COVESA/capicxx-core-runtime/blob/c4351ee6972890b225ec9d4984c8f4fa9dd09ae8/include/CommonAPI/Types.hpp#L92-L98
Is there any reason vsomeip is attempting to change the type? I think sticking to the platform defined type is much safer. I've also prepared #561 to use the types more consistently throughout vsomeip. I haven't removed the lines in
primitive_types.hpp
yet but will probably do so - I just wanted to first ask if there was a reason.The text was updated successfully, but these errors were encountered: