Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions always true in _get_queryables() #1543

Open
anesson-cs opened this issue Feb 25, 2025 · 0 comments
Open

Conditions always true in _get_queryables() #1543

anesson-cs opened this issue Feb 25, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@anesson-cs
Copy link
Collaborator

Describe the bug
In _get_queryables(), in the statement if md_mapping is not None and isinstance(md_mapping, list), the first condition is always True because md_mapping is either a tuple or a list and its default value is (None, NOT_MAPPED). A new condition must be found instead.

Just below, the statement if search_param is not None is also always True because search_param is set with get_search_param() which returns a string. It may be replaced by if search_param to check is it not an empty string or removed.

@anesson-cs anesson-cs added the bug Something isn't working label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant