installer - Notices and recommendations (#6069)

* change installer page to Notices and recommendations

* update

CHANGELOG

@@ -174,6 +174,7 @@ Cacti CHANGELOG
 -feature#6033: Allow Admins to see when a template was last modified
 -feature#6034: Allow Users to Drill Up from CDEF's and VDEF's to Graphs and Graph Templates
 -feature#6044: Enable the capabilities to view historical Classical Cacti Report from the GUI
+-feature#6063: Change installer page Input Validation Whitelist Protection to Recommendations 
 -feature#6066: Enable Drag and Drop for External Links
 -feature: Allow messages to be popup notifications
 -feature: Upgrade billboard.js to version 3.14.1

install/install.js

@@ -479,7 +479,7 @@ function processStepCheckTables(StepData) {
 
 }
 
-function processStepInputValidation(StepData) {
+function processStepNoticesRecomendations(StepData) {
 	if ($('#confirm').length) {
 		$('#confirm').click(function() {
 			if ($(this).is(':checked')) {
@@ -690,7 +690,7 @@ function performStep(installStep, suppressRefresh, forceReload) {
 			} else if (data.Step == STEP_BINARY_LOCATIONS) {
 				processStepBinaryLocations(data.StepData);
 			} else if (data.Step == STEP_INPUT_VALIDATION) {
-				processStepInputValidation(data.StepData);
+				processStepNoticesRecomendations(data.StepData);
 			} else if (data.Step == STEP_PROFILE_AND_AUTOMATION) {
 				processStepProfileAndAutomation(data.StepData);
 			} else if (data.Step == STEP_TEMPLATE_INSTALL) {

lib/installer.php

@@ -1882,7 +1882,7 @@ public function processCurrentStep() {
 			case Installer::STEP_PERMISSION_CHECK:
 				return $this->processStepPermissionCheck();
 			case Installer::STEP_INPUT_VALIDATION:
-				return $this->processStepInputValidation();
+				return $this->processStepNoticesRecomendations();
 			case Installer::STEP_PROFILE_AND_AUTOMATION:
 				return $this->processStepProfileAndAutomation();
 			case Installer::STEP_TEMPLATE_INSTALL:
@@ -2617,8 +2617,11 @@ public function processStepPermissionCheck() {
 		return $output;
 	}
 
-	public function processStepInputValidation() {
-		$output  = Installer::sectionTitle(__('Input Validation Whitelist Protection'));
+	public function processStepNoticesRecomendations() {
+		$output  = Installer::sectionTitle(__('Linux kernel security modules'));
+		$output .= Installer::sectionNormal(__('Cacti needs to establish network connections, execute binaries and write files to work. Linux security features such as <b>SELinux</b>, <b>AppArmor</b> or <b>ModSecurity</b> may cause Cacti to become inoperable in some configurations. If problems occur, check the settings of these security tools.<br/><br/>'));
+
+		$output .= Installer::sectionTitle(__('Input Validation Whitelist Protection'));
 		$output .= Installer::sectionNormal(__('Cacti Data Input methods that call a script can be exploited in ways that a non-administrator can perform damage to either files owned by the poller account, and in cases where someone runs the Cacti poller as root, can compromise the operating system allowing attackers to exploit your infrastructure.'));
 		$output .= Installer::sectionNormal(__('Therefore, several versions ago, Cacti was enhanced to provide Whitelist capabilities on the these types of Data Input Methods.  Though this does secure Cacti more thoroughly, it does increase the amount of work required by the Cacti administrator to import and manage Templates and Packages.'));
 		$output .= Installer::sectionNormal(__('The way that the Whitelisting works is that when you first import a Data Input Method, or you re-import a Data Input Method, and the script and or arguments change in any way, the Data Input Method, and all the corresponding Data Sources will be immediately disabled until the administrator validates that the Data Input Method is valid.'));
@@ -2632,7 +2635,7 @@ public function processStepInputValidation() {
 				'</ul>'
 		);
 
-		$output .= Installer::sectionNormal(__('It is strongly suggested that you update your config.php to enable this feature by uncommenting the <b>$input_whitelist</b> variable and then running the three CLI script options above after the web based install has completed.'));
+		$output .= Installer::sectionNormal(__('It is strongly suggested that you update your config.php to enable this feature by uncommenting the <b>$input_whitelist</b> variable and then running the three CLI script options above after the web based install has completed.<br/><br/>'));
 
 		$output .= Installer::sectionNormal(__('Check the Checkbox below to acknowledge that you have read and understand this security concern'));