Fix: #6089 - Cannot Add New Users due to incorrect array structure (#…

…6093)

* Fix: #6089 - Cannot Add New Users due to incorrect array structure

* QA: Use the get_auth_realms(true) as initially intended.

Note, Basic auth as a login realm should never happen.

CHANGELOG

@@ -1,6 +1,7 @@
 Cacti CHANGELOG
 
 1.2.30
+-issue#6089: Cannot Add New User due to incorrect array structure
 -issue#6090: Undefined function warnings in Automation
 
 1.2.29

auth_login.php

@@ -324,11 +324,11 @@
 								$realms = api_plugin_hook_function('login_realms',
 									array(
 										'1' => array(
-											'name' => __('Local'),
+											'name'     => __('Local'),
 											'selected' => false
 										),
 										'2' => array(
-											'name' => __('LDAP'),
+											'name'     => __('LDAP'),
 											'selected' => true
 										)
 									)

lib/auth.php

@@ -519,13 +519,13 @@ function get_auth_realms($login = false) {
 		if (cacti_sizeof($drealms)) {
 			if ($login) {
 				$new_realms['0'] = array(
-					'name' => __('Local'),
+					'name'     => __('Local'),
 					'selected' => false
 				);
 
 				foreach($drealms as $realm) {
 					$new_realms[1000+$realm['domain_id']] = array(
-						'name' => $realm['domain_name'],
+						'name'     => $realm['domain_name'],
 						'selected' => false
 					);
 				}
@@ -549,13 +549,18 @@ function get_auth_realms($login = false) {
 
 			return $new_realms;
 		}
+	} elseif ($login) {
+		return array(
+			'0' => array('name' => __('Local')),
+			'3' => array('name' => __('LDAP'))
+		);
+	} else {
+		return array(
+			'0' => __('Local'),
+			'3' => __('LDAP'),
+			'2' => __('Web Basic'),
+		);
 	}
-
-	return array(
-		'0' => ['name' => __('Local')],
-		'3' => ['name' => __('LDAP')],
-		'2' => ['name' => __('Web Basic')],
-	);
 }
 
 /**