Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #6089 - Cannot Add New Users due to incorrect array structure #6093

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

TheWitness
Copy link
Member

This fixes the defect introduced in d9ea74f and corrects array structure where it had been modified.

@TheWitness TheWitness requested a review from netniV February 6, 2025 14:00
Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fix goes the right way. We should not be returning two different structures of array from a single small function like this.

@TheWitness
Copy link
Member Author

It's always been a two dimensional array

realms = array(
id1 => name1,
id2 => name2,
...
);

You made a change to add the 'selected' and 'name' attributes to set the default selected on the backend and added those two attributes. It's the only place on Cacti that it's done. So, I would prefer we just use this. We don't need to be doing major re-designs in the 1.2.x branch.

Note, Basic auth as a login realm should never happen.
@TheWitness TheWitness requested a review from netniV February 7, 2025 14:48
@TheWitness
Copy link
Member Author

@netniV, please re-review. I'm okay keeping with a single function for the moment. I don't want to invest too much time in 1.2.x at this point.

@TheWitness TheWitness merged commit db80934 into 1.2.x Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants