percentage bandwidth calculation by thold plugin is wrong

[gj00354347]

Describe the bug
Hi Team ,

we are having a threshold for interface traffic in cacti 1.2.28 and thold plugin version 1.2.0 . there we have a legacy device having small bandwidth like 1000 Mbps . so when Thold plugin has to calculate the utilisation of bandwidth , it is doing incorrectly and the strange thing is that device is having 5 interfaces but this wrong calculation happens only with one and that too with only inbound traffic not even with outbound traffic of same interface .

below are a few important details

thold - 1.2.0
cacti - 1.2.28
rpn expression - |ds:traffic_in|,|query_ifSpeed|,1000,,/,800,

(yes ifSpeed as it's a legacy one and 1000 as it is suggested by device manager )

see in the snap , in graph legend that is being calculated correctly . even in Thold the outbound traffic percenstage is right as 1000 Mbps is bandwidth .

the inbound is 5 M so it should be 5 % not 194,631 but this is the value we are getting but see in outbound in thold calculation that is right .
so this is very strange that inbound calculation is wrong but inbound is wrong . as every now and then it is breaching and creating a false positive and a false alert and corresponding .

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Plugin (please complete the following information):

• Version: [e.g. 1.2]
• Source: [e.g. cacti.net, package, github]
• Identifier: [e.g. apt/yum package name or github commit ref]

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[xmacan]

Thold 1.2 is very old (released 2019). You should update to 1.8.x.
1.8.x needs Cacti 1.2.25, so you need older release (maybe 1.6) or update Cacti too.

[gj00354347]

@xmacan Thanks for the update . In fact my cacti is on 1.2.28 so we will update the Thold plugin .

we will upgrade the thold plugin after Christmas and New Year Change Freeze and then come back to you .

may be you can keep this in backlog status or awaiting feedback status .

Best Regards,
Gopal

[arno-st]

Are you sure of your RPN expression ?
|ds:traffic_in|,|query_ifSpeed|,1000,,/,800,

you take DS, then ifspeed but you do nothing with it, then 1000, then an empty coma, then you divide by 1000, then take 800 and do nothing with it.

[TheWitness]

That RPN is for sure wrong.

[gj00354347]

@TheWitness actually if you are seeing the double comma , that's typo , sorry for that ,as the same rpn is calculating the outbound traffic percentage very correctly as you can see in my snap attached previously .

the correct rpn is |ds:traffic_in|,|query_ifSpeed|,1000 , * ,/, 800,*

[TheWitness]

Yea, that looks better. You can insert that comment with three leading and trailing back ticks to show it in raw mono space BTW.

[TheWitness]

|ds:traffic_in|,|query_ifSpeed|,1000,*,/,800,*