Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action and hook for fypp #61

Closed
jatkinson1000 opened this issue Nov 6, 2023 · 1 comment · Fixed by #60
Closed

Add action and hook for fypp #61

jatkinson1000 opened this issue Nov 6, 2023 · 1 comment · Fixed by #60
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jatkinson1000
Copy link
Member

jatkinson1000 commented Nov 6, 2023

We should add a hook to generate the Fortran source for FTorch from fypp.
This will mean that the full source is in the repo and can be used directly and in documentation.

For developers this would mean they edit the fypp file and then push that, with F90 being generated by the hook.

@jatkinson1000 jatkinson1000 changed the title Agg github action for fypp Add github action for fypp Nov 6, 2023
@jatkinson1000 jatkinson1000 changed the title Add github action for fypp Add hook for fypp Nov 6, 2023
@jatkinson1000
Copy link
Member Author

A hook has been added as part of #60 but pre-commit hooks cannot modify filed that are committed.
Instead it must warn the user and reject the commit until conditions are met.
Pre-commit hooks cannot be forced upon users, so to keep security on the repo side it should be modified into a workflow.

@jatkinson1000 jatkinson1000 changed the title Add hook for fypp Add action and hook for fypp Nov 18, 2023
@jatkinson1000 jatkinson1000 self-assigned this Nov 18, 2023
@jatkinson1000 jatkinson1000 linked a pull request Nov 18, 2023 that will close this issue
7 tasks
@jatkinson1000 jatkinson1000 added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant