Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop codons are usually "*" not "x" #6

Open
Koeng101 opened this issue Oct 18, 2022 · 3 comments
Open

Stop codons are usually "*" not "x" #6

Koeng101 opened this issue Oct 18, 2022 · 3 comments

Comments

@Koeng101
Copy link

{"taa", 'x'},
{"tga", 'x'},
{"tag", 'x'},

Small nitpick : stop codons are usually represented with "*", not "x"

@CamelCaseCam
Copy link
Owner

That's actually fair. Note to self: add support for * in an amino sequence

@CamelCaseCam
Copy link
Owner

I think I chose 'x' because '*' could have its own special meaning in the language, but I'd only been doing synbio for a month when I started the C# version of this project, so it might have been stylistic

@CamelCaseCam
Copy link
Owner

Completely forgot about this, but I looked into it and it's an easy fix. GIL has support for non-canonical amino acids, so I'll just add a * key to the gilEncoding files so you can use either. This should be out with the next bool release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants