Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference refactoring #166

Open
PonteIneptique opened this issue May 11, 2018 · 0 comments
Open

Reference refactoring #166

PonteIneptique opened this issue May 11, 2018 · 0 comments
Labels
cts opinions requested When a change need to get opinion before being done refactoring-discussion

Comments

@PonteIneptique
Copy link
Member

PonteIneptique commented May 11, 2018 •
edited
Loading

MyCapytain.common.reference.Reference is gonna be refactored but it will be much lighter than Citation refactoring. On the other end, it's gonna lead to breaking change as the Reference object was only valid within the CTS paradigm.

Current changes

Breaking changes:

  • (Proposed) In an effort of having the same return value type, I propose to move from returning Reference object in .start and .end to return string instead. This will make cross object much simpler.
@PonteIneptique PonteIneptique added the opinions requested When a change need to get opinion before being done label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cts opinions requested When a change need to get opinion before being done refactoring-discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PonteIneptique