Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit speakers list length in video card #50

Closed
Betree opened this issue Jan 28, 2019 · 2 comments
Closed

Limit speakers list length in video card #50

Betree opened this issue Jan 28, 2019 · 2 comments
Labels
bounty This issue has a bounty attached bounty > 20€ complexity > simple Simple tasks (usually a few hours) frontend Everything for https://github.com/CaptainFact/captain-fact-frontend good first issue Good for newcomers Up For Grabs Want to help? This task is a good one!

Comments

@Betree
Copy link
Member

Betree commented Jan 28, 2019 •
edited
Loading

Issue

Preview

Solution

We should limit the number of speakers shown on the card to 5. If more speakers are presents, we should display the last ones with something like and x others.
The missing names should be set in title to be displayed when hovered.

Example
speaker1, speaker2, speaker3, speaker4, speaker5 and 4 others.

Suggested by Timothée
@Betree Betree added good first issue Good for newcomers Up For Grabs Want to help? This task is a good one! frontend Everything for https://github.com/CaptainFact/captain-fact-frontend complexity > simple Simple tasks (usually a few hours) labels Jan 29, 2019
@Betree Betree added bounty This issue has a bounty attached bounty > 20€ labels Mar 12, 2019
@Betree
Copy link
Member Author

Betree commented Mar 12, 2019

💸 A 20€ bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with 20€ when the Pull Request is reviewed, accepted and merged. More info.

@Vayel Vayel mentioned this issue Mar 17, 2019
Merged
@Betree
Copy link
Member Author

Betree commented Mar 25, 2019

Closed in CaptainFact/captain-fact-frontend#378

@Vayel You can claim the bounty by submitting a 20€ expense on https://opencollective.com/captainfact_io/expenses/new. Please mention the issue number (50) on the expense title.

@Betree Betree closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty This issue has a bounty attached bounty > 20€ complexity > simple Simple tasks (usually a few hours) frontend Everything for https://github.com/CaptainFact/captain-fact-frontend good first issue Good for newcomers Up For Grabs Want to help? This task is a good one!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Betree