Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimateSubAbility rework #6816

Open
tool4ever opened this issue Jan 21, 2025 · 0 comments · May be fixed by #6819
Open

AnimateSubAbility rework #6816

tool4ever opened this issue Jan 21, 2025 · 0 comments · May be fixed by #6819
Assignees
@tool4ever
Labels
Game Mechanics keep no stale Rules compliance Bringing the engine or cards closer to CR

Comments

@tool4ever
Copy link
Contributor

Judges say the effect from it doesn't exist while doing ETB lookahead:
https://old.reddit.com/r/askajudge/comments/1ggxkoo/containment_priest_enduring_creatures/

My current idea in GameAction.changeZone:

  1. Moved RE
  2. check Cause param and create/reuse DetachedCardEffect
  3. Remember the moving card onto effect
  4. Apply statics, do ChangesZone trigger etc.

So this might actually be good for us to also clean up the multiple code for it in different effects.
@tool4ever tool4ever mentioned this issue Jan 21, 2025
Open
@tool4ever tool4ever added Game Mechanics Rules compliance Bringing the engine or cards closer to CR keep no stale labels Jan 21, 2025
@tool4ever tool4ever self-assigned this Jan 21, 2025
@tool4ever tool4ever linked a pull request Jan 21, 2025 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tool4ever tool4ever

Labels
Game Mechanics keep no stale Rules compliance Bringing the engine or cards closer to CR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AnimateSubAbility rework tool4ever/forge
1 participant
@tool4ever