Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimateSubAbility rework #6819

Merged
merged 21 commits into from
Jan 28, 2025
Merged

AnimateSubAbility rework #6819

merged 21 commits into from
Jan 28, 2025

Conversation

tool4ever
Copy link
Contributor

@tool4ever tool4ever commented Jan 21, 2025

  • add zone ordering
  • update remaining scripts
  • update remaining effects

Closes #6816

@tool4ever tool4ever added Game Mechanics Rules compliance Bringing the engine or cards closer to CR labels Jan 21, 2025
@tool4ever tool4ever marked this pull request as draft January 21, 2025 20:47
@tool4ever
Copy link
Contributor Author

Already works like I want:
image
⬇️ only one will get creature type removed from timestamp order
image

@tool4ever
Copy link
Contributor Author

Well I maybe should have started with a more complicated one first...
Had to rearrange some parts so when Bronzehide Lion returns as Aura it still gets a chance to become attached.
Now I'm a bit less happy with it and need to check if this causes no bad side effects ;(

If a nontoken permanent is a copy of Bronzehide Lion, it returns from its owner’s graveyard as an Aura with the two abilities granted by Bronzehide Lion and none of its normal abilities. If it has any enters-the-battlefield replacement effects, those won’t apply. The Aura keeps its name, colors, and any supertypes it may have.

Also the bold part confuses me:

  • Is that a contradiction to the ruling that Containment Priest can exile a returning Enduring Innocence?
  • Unless I find a flaw in my thought process might have to ask Judge next 🤔

@Hanmac
Copy link
Contributor

Hanmac commented Jan 22, 2025

Well I maybe should have started with a more complicated one first... Had to rearrange some parts so when Bronzehide Lion returns as Aura it still gets a chance to become attached. Now I'm a bit less happy with it and need to check if this causes no bad side effects ;(

If a nontoken permanent is a copy of Bronzehide Lion, it returns from its owner’s graveyard as an Aura with the two abilities granted by Bronzehide Lion and none of its normal abilities. If it has any enters-the-battlefield replacement effects, those won’t apply. The Aura keeps its name, colors, and any supertypes it may have.

Also the bold part confuses me:

* Is that a contradiction to the ruling that _Containment Priest_ can exile a returning _Enduring Innocence_?

* Unless I find a flaw in my thought process might have to ask Judge next 🤔

ugh that sounds extra ugly ... i think the difference is that Bronzehide Lion would remove its own abilities, so it would also remove any affected replacement effects

@tool4ever
Copy link
Contributor Author

Based on the Judge answer it looks like this rules area is in pretty bad shape
Accordingly I will restore/align with the old behaviour which will respect the ruling at least until something new and official gets posted

@tool4ever tool4ever marked this pull request as ready for review January 24, 2025 12:58
Copy link
Contributor

@Hanmac Hanmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only things i don't like are the ones that create the Effect first ... and i wish the ChangesZone Effect would know about this :/

Copy link
Contributor

@Hanmac Hanmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the test cases

@tool4ever
Copy link
Contributor Author

@Hanmac
was the EffectZone changes

@Agetian Agetian merged commit 99fd4d9 into Card-Forge:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game Mechanics Rules compliance Bringing the engine or cards closer to CR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimateSubAbility rework
3 participants