Telemetry tab labels #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliasJRH
requested changes
Feb 2, 2025
There was a problem hiding this comment.
Great work! I tweaked the code a bit to fix the spacing issue, now the top bar takes up the whole width of the window. Seeing as how you moved the log output to a different tab, can you remove the P&ID tab as well and add the button back to show the P&ID window?
main_window/main_window.py
Outdated
| @@ -71,7 +86,7 @@ def __init__(self, parent=None): | |||
|
|
|||
| # Show P&ID Diagram handler | |||
| self.pid_window = PIDWindow() | |||
| self.ui.showPIDButton.clicked.connect(self.open_pid_window) | |||
| #self.ui.showPIDButton.clicked.connect(self.open_pid_window) | |||
There was a problem hiding this comment.
Could you add this button back to the UI? It should have the correct functionality.
EliasJRH
added a commit
that referenced
this pull request
Feb 10, 2025
* It works???? * It works???? * experiment * join em all * Cleanup * Remove datagram print statement * Clean up * Remove interface dropdown * Remove references to interface dropdown * Remove join check * Add new files to readme * Telemetry tab labels (#51) * Removed part of main window ui and added new log tab * Added labels to main window * Fixed whitespace issues, moved logo * Removed part of main window ui and added new log tab * Added labels to main window * Fixed whitespace issues, moved logo * Coded labels and readings for sensors * Commented PID window to avoid error (FIX LATER) * Fixed labels, added Celsius * Added functionality to readings labels * Added comments for clarity * Fix spacing issue * Added PID button and deleted PID tab --------- Co-authored-by: jackricketts <[email protected]> Co-authored-by: Elias Hawa <[email protected]> * It works???? * experiment * join em all * It works???? * Cleanup * Clean up * Remove interface dropdown * Remove references to interface dropdown * Remove join check --------- Co-authored-by: Matteo Golin <[email protected]> Co-authored-by: Brian Xu <[email protected]> Co-authored-by: jackricketts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33 Cleared part of the main window ui and used the blank space for telemetry reading values. Added functionality to them so that they display the information that the graphs has too.