Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 2.4.1 and ffmpeg7 need issue #1586

Open
Pro-pra opened this issue Nov 16, 2024 · 0 comments
Open

Bug: 2.4.1 and ffmpeg7 need issue #1586

Pro-pra opened this issue Nov 16, 2024 · 0 comments
Labels

Comments

@Pro-pra
Copy link

Pro-pra commented Nov 16, 2024

Observed Behavior

On build stage this error:

decklink_producer.cpp:641:52: error: 'AVFilterLink' {aka 'struct AVFilterLink'} has no member named 'min_samples'
  641 |                     audio_filter_.sink->inputs[0]->min_samples = audio_cadence_[0];

Expected behaviour

In ffmpeg7 min_samples i see in libavfilter/filters.h but it is not installed by default
https://github.com/FFmpeg/FFmpeg/blob/a5f0daf8433899d7d644523156ad1078301543f8/libavfilter/filters.h#L153

Ok, i patch ffmpeg7 and install libavfilter/filters.h

Also patch casparcg-server:

--- a/modules/decklink/producer/decklink_producer.cpp	2024-10-08 23:45:44.000000000 +0900
+++ b/modules/decklink/producer/decklink_producer.cpp	2024-11-16 10:57:32.174492429 +0900
@@ -51,7 +51,7 @@
 #endif
 extern "C" {
 #include <libavcodec/avcodec.h>
-#include <libavfilter/avfilter.h>
+#include <libavfilter/filters.h>
 #include <libavfilter/buffersink.h>
 #include <libavfilter/buffersrc.h>
 #include <libavformat/avformat.h>

And this not help me :(( AVFilterLink not have min_samples
https://github.com/FFmpeg/FFmpeg/blob/a5f0daf8433899d7d644523156ad1078301543f8/libavfilter/avfilter.h#L578

Steps to reproduce

build with ffmpeg7

Environment

gcc-14
ffmpeg-7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant