Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billboard clamping does not work with tilesets inside of PrimitiveCollection #12454

Open
angrycat9000 opened this issue Jan 29, 2025 · 1 comment
Labels
category - 3d tiles good first issue An opportunity for first time contributors type - bug

Comments

@angrycat9000
Copy link
Contributor

What happened?

When nesting a Cesium3DTileset inside of a PrimitiveCollection clamping billoards to the ground no longer works.

Reproduction steps

Sandcastlewith tileset added directly to viewer.scene.primitives . Billboard appears on top of 3d tileset as expected

Image

Sandcastle modified to add tileset to a primitive collection and the billboard is not clamped.

Image

Sandcastle example

No response

Environment

Browser: Chrome
CesiumJS Version:
Operating System: Windows

@ggetz
Copy link
Contributor

ggetz commented Feb 6, 2025

Thanks for the report @angrycat9000!

I looks like we're only checking for top-level 3D Tiles primitives, and not traversing any collections.

@ggetz ggetz added category - 3d tiles good first issue An opportunity for first time contributors and removed needs triage labels Feb 6, 2025
CodyBu added a commit to CodyBu/cesium that referenced this issue Feb 18, 2025
@CodyBu CodyBu mentioned this issue Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - 3d tiles good first issue An opportunity for first time contributors type - bug
Projects
None yet
Development

No branches or pull requests

2 participants