Reduce number of CSP + Turbolinks complaints #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review my lazy CSP fixes PR @sjaustirni |
sjaustirni
approved these changes
May 10, 2021
| <%= csrf_meta_tags %> | ||
| <%= csp_meta_tag %> | ||
|
|
||
| <meta charset="utf-8"> | ||
| <meta name="turbolinks-cache-control" content="no-cache"> |
There was a problem hiding this comment.
(suggestion): Removing this line seems to fix the back button issue (since we are caching now, we don't really need the full page reload on back button click, as the bundle is still valid). (additional context).
(suggestion): When testing, remember to open the page in a new tab after removing the line. Otherwise you can go back to the history when this line was still being served and that will trigger a CSP error! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #272
Description of Changes
Reload stylesheet for Turbolinks, so the CSP allows it.
Also, remove inline styles and replace with cards, so the CSP stops complaining.
Did not fix: CSP complains on back button.
Screenshots
Problem Solved
CSP was throwing errors into the console due to inline styles and unreloaded stylesheets from turbolinks.
PR Checklist