-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Detectors and Probers for target languages #53
Comments
Hi, Sorry for the late response. What do you mean with this? |
Hello! I created a pr #63 for ease of understanding. In order to detect the encoding prober's objects are created. They are defined for multiple languages. With a small sample of characters to detect the encoding, conflicts may arise between the encodings due to the possibility of being a character code in different languages. But, what if we need to define an encoding, knowing that it can belong to only one language? Then you can restrict yourself to probers only for a given language, reducing the likelihood of incorrect detections. PS. Sorry for my english. |
sound good, but now sure how easy it is to change that is this code base. |
It seems to me that first we need to try to single out single-byte probers by language, as models |
Hello, @304NotModified ! We can make breaking changes and override, using |
do you mean if making breaking changes in src/core is OK? I think it is. We should make them internal also |
I think it would be nice if we could just change the source in I just have the idea of separating probers as models into languages (however, it will take a lot of time, there are about 100 of them). And it would be nice then to change the namespace |
Hello!
It may be worth adding the ability to determine the encoding if you know which target language?
The text was updated successfully, but these errors were encountered: