Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with lowerCase and upperCase to match with the lyrics #25

Open
martinezluciano opened this issue Mar 10, 2023 · 3 comments
Open

Comments

@martinezluciano
Copy link

martinezluciano commented Mar 10, 2023

With this simple workaround works a little better, but if the lowerCase letters are in the middle of the song, it can't be found
Another issue with this solution is that the performance is affected because is neccesary repeat whole process.

`

songs = universal_search(media_info.name.lower(), artists)
if(songs == []):
    songs= universal_search(media_info.name.lower(), media_info.artists.lower())
if(songs == []):
    songs= universal_search(media_info.name, media_info.artists.lower())
if(songs == []):
    songs= universal_search(media_info.name, media_info.artists)
    `

so that is all, good job, awesome app !

@ChenghaoMou
Copy link
Owner

Thanks for the suggestion. Do you have an example where it failed so that I can test it?

@martinezluciano
Copy link
Author

sure, I will adding some songs.
MediaInformation(name='Without Me', artists='Eminem', position=4.350999832153, state=2, durantion=290.0)
MediaInformation(name='Stan', artists='Eminem', position=317.200012207031, state=2, durantion=404.0)

another issue, found the lyrics but does not work.
[Song(title='The Next Episode (Instrumental Version)', artists='dr. dre', target_title='The Next Episode', target_artists='dr. dre', lyric='[00:00.000]

@ChenghaoMou
Copy link
Owner

For the two songs you shared, it found the lyrics fine without any change. Please let me know if I am missing something.

CleanShot 2023-03-21 at 19 04 43
CleanShot 2023-03-21 at 19 06 31

For the third one, unfortunately, Spotify does not return the full list of artists for this song. It only gave me Dr. Dre, so it ended up matching to an instrumental version which does not have any lyrics but has Dr. Dre as the only artist. Songs with Dr. Dre,Snoop Dogg ended up ranked behind that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants