feat: allow for connections to different hosts for wallet and full node #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
reviewed
Jan 11, 2025
app/api/dependencies.py
Outdated
| @@ -77,7 +77,7 @@ async def _get_rpc_client( | |||
| async def get_wallet_rpc_client() -> AsyncIterator[WalletRpcClient]: | |||
| async for _ in _get_rpc_client( | |||
| node_type=NodeType.WALLET, | |||
| self_hostname=settings.CHIA_HOSTNAME, | |||
| self_hostname=settings.CHIA_WALLET_HOSTNAME or settings.CHIA_HOSTNAME, | |||
There was a problem hiding this comment.
I would write this using ternary
self_hostname = setting.CHIA_WALLET_HOSTNAME if setting.CHIA_WALLET_HOSTNAME else settings.CHIA_HOSTNAME
although I'm not sure I have a good reason for it
There was a problem hiding this comment.
I don't have a good reason for the way I was doing it either, so I changed it to your suggestion
emlowe
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.